Re: mwifiex: propagate error if IRQ request fails in mwifiex_sdio_of()

From	Javier Martinez Canillas <javier@osg.samsung.com>
Newsgroups	linux.kernel
Subject	Re: mwifiex: propagate error if IRQ request fails in mwifiex_sdio_of()
Date	2016-09-06 14:20 +0200
Message-ID	<senw5-1UN-7@gated-at.bofh.it> (permalink)
References	<senw5-1UN-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello Kalle,

On 09/03/2016 12:35 PM, Kalle Valo wrote:
> Javier Martinez Canillas <javier@osg.samsung.com> wrote:
>> If request_irq() fails in mwifiex_sdio_probe_of(), only an error message
>> is printed but the actual error is not propagated to the caller function.
>>
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> 
> What's the conclusion with this patch? Should I drop it or take it?
> 
> (The discussion is available from the patchwork link in the signature.)
> 

My understanding is that Arend agrees with the patch and that the question
raised was caused by looking at an older kernel version. IOW, the patch is
OK and should be picked.

I'm adding Arend to cc, so can comment in case I misunderstood him though.

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: mwifiex: propagate error if IRQ request fails in  mwifiex_sdio_of() Javier Martinez Canillas <javier@osg.samsung.com> - 2016-09-06 14:20 +0200
  Re: mwifiex: propagate error if IRQ request fails in  mwifiex_sdio_of() Javier Martinez Canillas <javier@osg.samsung.com> - 2016-09-08 18:00 +0200
  RE: mwifiex: propagate error if IRQ request fails in  mwifiex_sdio_of() Amitkumar Karwar <akarwar@marvell.com> - 2016-09-08 18:00 +0200

csiph-web