RE: [PATCH v3] lib/bitmap.c: enhance bitmap syntax

From	Noam Camus <noamca@mellanox.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH v3] lib/bitmap.c: enhance bitmap syntax
Date	2016-09-06 14:50 +0200
Message-ID	<senZ8-269-19@gated-at.bofh.it> (permalink)
References	<rVULT-1ud-7@gated-at.bofh.it> <rVULT-1ud-9@gated-at.bofh.it> <rVULT-1ud-5@gated-at.bofh.it> <rVULT-1ud-15@gated-at.bofh.it> <rWbjI-3eT-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Ben, Pan

This is a second ping.

Will appreciate your feedback wither changing syntax will do the change or that I need a different approach to achieve such enhancement.
See below for new syntax suggestion.

-Noam 

-----Original Message-----
From: Noam Camus 
Sent: Monday, August 01, 2016 7:53 AM
To: 'Pan Xinhui' <xinhui@linux.vnet.ibm.com>; 'decot@googlers.com' <decot@googlers.com>; 'Ben Hutchings' <ben@decadent.org.uk>
Cc: 'ben@decadent.org.uk' <ben@decadent.org.uk>; 'davem@davemloft.net' <davem@davemloft.net>; 'akpm@linux-foundation.org' <akpm@linux-foundation.org>; 'linux-kernel@vger.kernel.org' <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v3] lib/bitmap.c: enhance bitmap syntax

Ping...

-----Original Message-----
From: Noam Camus 
Sent: Monday, July 18, 2016 10:06 AM
To: Pan Xinhui <xinhui@linux.vnet.ibm.com>; decot@googlers.com
Cc: ben@decadent.org.uk; davem@davemloft.net; akpm@linux-foundation.org; linux-kernel@vger.kernel.org
Subject: RE: [PATCH v3] lib/bitmap.c: enhance bitmap syntax

> From: Pan Xinhui [mailto:xinhui@linux.vnet.ibm.com]
> Sent: Sunday, July 17, 2016 4:59 PM

>>
>> I really think it is better to implement one function to generic a string which contanis the cpus you want to boot on, then pass this string to  __bitmap_parselist.
>>
> sorry, typos.
> generic -> generate.

Please explain how this will solve the syntax issue Ben commented on?

Another syntax which might be simpler is:
<first cpu-last cpu>:<numcpus selected from group>/<cpus group size> e.g.
0-1023:1/2 <==> 0,2,4,...,1022
1-1023:1/2 <==> 1,3,5,...,1023

So basically no need for modulo only divide the list into groups of cpus and for each group choose cpus from group start.
It is basically achieves same and hopefully more  simpler and more eligible for such generic code.

Please let me know what you think?
Is it good direction to change the syntax, or that I should turn into different approach (like Pan suggested)?

Noam.

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

RE: [PATCH v3] lib/bitmap.c: enhance bitmap syntax Noam Camus <noamca@mellanox.com> - 2016-09-06 14:50 +0200
  Re: [PATCH v3] lib/bitmap.c: enhance bitmap syntax Ben Hutchings <ben@decadent.org.uk> - 2016-09-06 15:40 +0200

csiph-web