Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1477258

Re: [PATCH 1/3] arm64: dts: berlin4ct: add missing unit name to /soc node

From Jisheng Zhang <jszhang@marvell.com>
Newsgroups linux.kernel
Subject Re: [PATCH 1/3] arm64: dts: berlin4ct: add missing unit name to /soc node
Date 2016-09-06 12:30 +0200
Message-ID <selNE-MN-23@gated-at.bofh.it> (permalink)
References <sekye-8q9-23@gated-at.bofh.it> <sekye-8q9-29@gated-at.bofh.it> <selND-MN-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi Mark,

On Tue, 6 Sep 2016 11:22:08 +0100 Mark Rutland wrote:

> On Tue, Sep 06, 2016 at 04:55:55PM +0800, Jisheng Zhang wrote:
> > This patch fixes the following DTC warning with W=1:
> > 
> > "Node /soc has a reg or ranges property, but no unit name"
> > 
> > Signed-off-by: Jisheng Zhang <jszhang@marvell.com>  
> 
> The node is only compatible with simple-bus, and so shouldn't have a
> reg.

IIUC, the warning is caused by "ranges = <0 0 0xf7000000 0x1000000>;"

Thanks,
Jisheng

> 
> Why not remove the reg?
> 
> Mark
> 
> > ---
> >  arch/arm64/boot/dts/marvell/berlin4ct.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm64/boot/dts/marvell/berlin4ct.dtsi b/arch/arm64/boot/dts/marvell/berlin4ct.dtsi
> > index 099ad93..2d6f91f 100644
> > --- a/arch/arm64/boot/dts/marvell/berlin4ct.dtsi
> > +++ b/arch/arm64/boot/dts/marvell/berlin4ct.dtsi
> > @@ -134,7 +134,7 @@
> >  			     <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>;
> >  	};
> >  
> > -	soc {
> > +	soc@f7000000 {
> >  		compatible = "simple-bus";
> >  		#address-cells = <1>;
> >  		#size-cells = <1>;
> > -- 
> > 2.9.3
> >   

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 1/3] arm64: dts: berlin4ct: add missing unit name to /soc node Jisheng Zhang <jszhang@marvell.com> - 2016-09-06 11:10 +0200
  Re: [PATCH 1/3] arm64: dts: berlin4ct: add missing unit name to /soc  node Mark Rutland <mark.rutland@arm.com> - 2016-09-06 12:30 +0200
    Re: [PATCH 1/3] arm64: dts: berlin4ct: add missing unit name to  /soc node Jisheng Zhang <jszhang@marvell.com> - 2016-09-06 12:30 +0200
      Re: [PATCH 1/3] arm64: dts: berlin4ct: add missing unit name to /soc  node Mark Rutland <mark.rutland@arm.com> - 2016-09-06 13:00 +0200
        Re: [PATCH 1/3] arm64: dts: berlin4ct: add missing unit name to /soc  node Stephen Warren <swarren@wwwdotorg.org> - 2016-09-06 18:10 +0200

csiph-web