Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1477154

Re: [PATCH] video: mxsfb: get supply regulator optionally

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

On 04/09/16 07:26, Stefan Agner wrote:
> The lcd-supply is meant to be optional, there are several device-
> trees not specifying it and the code handles error values silently.
> Therefor, avoid creating a dummy regulator (and the associated
> warning) by using devm_regulator_get_optional.
> 
> While at it, document that fact also in the device-tree bindings.

The binding change looks correct, but using
devm_regulator_get_optional() does not sound correct.

devm_regulator_get_optional() is to be used when the device in question
truly can function without the power supply. But if the supply is there,
it's just not controlled by the SW, devm_regulator_get() is to be used.

At least this is my understanding.

 Tomi

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] video: mxsfb: get supply regulator optionally Stefan Agner <stefan@agner.ch> - 2016-09-04 06:40 +0200
  Re: [PATCH] video: mxsfb: get supply regulator optionally Tomi Valkeinen <tomi.valkeinen@ti.com> - 2016-09-06 10:30 +0200
    Re: [PATCH] video: mxsfb: get supply regulator optionally Stefan Agner <stefan@agner.ch> - 2016-09-06 20:30 +0200
      Re: [PATCH] video: mxsfb: get supply regulator optionally Mark Brown <broonie@kernel.org> - 2016-09-07 00:30 +0200
      Re: [PATCH] video: mxsfb: get supply regulator optionally Tomi Valkeinen <tomi.valkeinen@ti.com> - 2016-09-07 09:30 +0200

csiph-web