Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1477152

Re: [RFC] zram: support page-based parallel write

Show all headers | View raw

On Tue, Sep 06, 2016 at 04:24:17PM +0900, Minchan Kim wrote:
> @@ -1464,6 +1908,9 @@ static int __init zram_init(void)
>  		num_devices--;
>  	}
>  
> +	if (create_workers())
> +		goto out_error;
> +
>  	return 0;
>  
>  out_error:
> @@ -1474,6 +1921,7 @@ static int __init zram_init(void)
>  static void __exit zram_exit(void)
>  {
>  	destroy_devices();
> +	destroy_workers();
>  }


Asymmetry --> "BUG".

...right?

(I have to admit that current implementation structure
is not easy to follow,
thus I'm not fully sure)


Thanks for working in this important area!

HTH,

Andreas Mohr

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC] zram: support page-based parallel write Minchan Kim <minchan@kernel.org> - 2016-09-06 09:30 +0200
  Re: [RFC] zram: support page-based parallel write Andreas Mohr <andi@lisas.de> - 2016-09-06 10:30 +0200
    Re: [RFC] zram: support page-based parallel write Minchan Kim <minchan@kernel.org> - 2016-09-08 04:40 +0200
  Re: [RFC] zram: support page-based parallel write Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-09-08 03:40 +0200
    Re: [RFC] zram: support page-based parallel write Minchan Kim <minchan@kernel.org> - 2016-09-08 05:00 +0200

csiph-web