Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1477074

[PATCH v2 3/3] perf record: Mark MAP_HUGETLB during synthesizing mmap events

From Wang Nan <wangnan0@huawei.com>
Newsgroups linux.kernel
Subject [PATCH v2 3/3] perf record: Mark MAP_HUGETLB during synthesizing mmap events
Date 2016-09-06 07:00 +0200
Message-ID <segEh-5Ai-9@gated-at.bofh.it> (permalink)
References <segEh-5Ai-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


During synthesizing mmap events, add MAP_HUGETLB map flag if the
source of mapping is file in hugetlbfs.

After this patch, perf can identify hugetlb mapping even if perf
is started after the mapping of huge pages (like perf top).

Signed-off-by: Wang Nan <wangnan0@huawei.com>
Reviewed-by: Nilay Vaish <nilayvaish@gmail.com>
Cc: Hou Pengyang <houpengyang@huawei.com>
Cc: He Kuang <hekuang@huawei.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/event.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/tools/perf/util/event.c b/tools/perf/util/event.c
index e20438b..23c3ebd 100644
--- a/tools/perf/util/event.c
+++ b/tools/perf/util/event.c
@@ -1,5 +1,6 @@
 #include <linux/types.h>
 #include <sys/mman.h>
+#include <api/fs/fs.h>
 #include "event.h"
 #include "debug.h"
 #include "hist.h"
@@ -248,6 +249,10 @@ int perf_event__synthesize_mmap_events(struct perf_tool *tool,
 	bool truncation = false;
 	unsigned long long timeout = proc_map_timeout * 1000000ULL;
 	int rc = 0;
+#ifdef MAP_HUGETLB
+	const char *hugetlbfs_mnt = hugetlbfs__mountpoint();
+	int hugetlbfs_mnt_len = hugetlbfs_mnt ? strlen(hugetlbfs_mnt) : 0;
+#endif
 
 	if (machine__is_default_guest(machine))
 		return 0;
@@ -342,6 +347,12 @@ out:
 
 		if (!strcmp(execname, ""))
 			strcpy(execname, anonstr);
+#ifdef MAP_HUGETLB
+		if (!strncmp(execname, hugetlbfs_mnt, hugetlbfs_mnt_len)) {
+			strcpy(execname, anonstr);
+			event->mmap2.flags |= MAP_HUGETLB;
+		}
+#endif
 
 		size = strlen(execname) + 1;
 		memcpy(event->mmap2.filename, execname, size);
-- 
1.8.3.4

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 0/3] perf report: Recognize hugetlb mapping as anon mapping Wang Nan <wangnan0@huawei.com> - 2016-09-06 07:00 +0200
  [PATCH v2 2/3] tools lib api fs: Add hugetlbfs filesystem detector Wang Nan <wangnan0@huawei.com> - 2016-09-06 07:00 +0200
    [tip:perf/core] tools lib api fs: Add hugetlbfs filesystem detector tip-bot for Wang Nan <tipbot@zytor.com> - 2016-09-09 08:00 +0200
  [PATCH v2 1/3] perf tools: Recognize hugetlb mapping as anon mapping Wang Nan <wangnan0@huawei.com> - 2016-09-06 07:00 +0200
    [tip:perf/core] perf tools: Recognize hugetlb mapping as anon  mapping tip-bot for Wang Nan <tipbot@zytor.com> - 2016-09-09 08:00 +0200
  [PATCH v2 3/3] perf record: Mark MAP_HUGETLB during synthesizing mmap events Wang Nan <wangnan0@huawei.com> - 2016-09-06 07:00 +0200
    [tip:perf/core] perf record: Mark MAP_HUGETLB when synthesizing  mmap events tip-bot for Wang Nan <tipbot@zytor.com> - 2016-09-09 08:00 +0200

csiph-web