Re: [PATCH] [media] pci: constify snd_pcm_ops structures

Path	csiph.com!1.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!newsfeed.datemas.de!weretis.net!feeder4.news.weretis.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Julia Lawall <julia.lawall@lip6.fr>
Newsgroups	linux.kernel
Subject	Re: [PATCH] [media] pci: constify snd_pcm_ops structures
Date	Thu, 08 Sep 2016 05:10:02 +0200
Message-ID	<seXSW-ls-5@gated-at.bofh.it> (permalink)
References	<seW0O-7wI-5@gated-at.bofh.it> <seXgd-8jt-3@gated-at.bofh.it>
X-Ironport-Av	E=Sophos;i="5.30,298,1470693600"; d="scan'208";a="235635274"
X-X-Sender	jll@hadrien
User-Agent	Alpine 2.10 (DEB 1266 2009-07-14)
MIME-Version	1.0
Content-Type	TEXT/PLAIN; charset=US-ASCII
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	22
Organization	linux.* mail to news gateway
X-Original-Cc	Mauro Carvalho Chehab <mchehab@kernel.org>, kernel-janitors@vger.kernel.org, Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>, Hans Verkuil <hans.verkuil@cisco.com>, Ismael Luceno <ismael@iodev.co.uk>, Bluecherry Maintainers <maintainers@bluecherrydvr.com>, Andy Walls <awalls@md.metrocast.net>, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Thu, 8 Sep 2016 11:08:06 +0800 (SGT)
X-Original-Message-ID	<alpine.DEB.2.10.1609081106070.6858@hadrien>
X-Original-References	<1473295479-24615-1-git-send-email-Julia.Lawall@lip6.fr> <20160908022755.mr45eulz4r7vfoo5@zver>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1478752

Show key headers only | View raw


On Thu, 8 Sep 2016, Andrey Utkin wrote:

> Thanks for looking into this.
> I have tested that it compiles and passes checks (C=2) cleanly after
> this patch.
>
> Acked-by: Andrey Utkin <andrey.utkin@corp.bluecherry.net>
>
> While we're at it, what about constification of
> *-core.c:static struct pci_driver *_pci_driver = {
> *-video.c:static struct vb2_ops *_video_qops = {
> *-video.c:static struct video_device *_video_template = {
>
> in drivers/media/pci/? Also there are even more similar entries not
> constified yet in drivers/media/, however I may be underestimating
> complexity of making semantic rules for catching that all.

I will check on these.  Thanks for the suggestion.

julia

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] [media] pci: constify snd_pcm_ops structures Julia Lawall <Julia.Lawall@lip6.fr> - 2016-09-08 03:10 +0200
  Re: [PATCH] [media] pci: constify snd_pcm_ops structures Andrey Utkin <andrey.utkin@corp.bluecherry.net> - 2016-09-08 04:30 +0200
    Re: [PATCH] [media] pci: constify snd_pcm_ops structures Julia Lawall <julia.lawall@lip6.fr> - 2016-09-08 05:10 +0200

csiph-web