Re: [PATCH] fs/proc/kcore.c: Omit kernel text area for hardened usercopy feature

From	Linus Torvalds <torvalds@linux-foundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] fs/proc/kcore.c: Omit kernel text area for hardened usercopy feature
Date	2016-09-08 01:00 +0200
Message-ID	<seTYZ-66s-7@gated-at.bofh.it> (permalink)
References	(4 earlier) <seFCF-59y-17@gated-at.bofh.it> <seO3g-298-31@gated-at.bofh.it> <seOmC-2g5-9@gated-at.bofh.it> <seQHM-3XU-23@gated-at.bofh.it> <seSzU-5iP-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Sep 7, 2016 at 2:24 PM, Jiri Olsa <jolsa@redhat.com> wrote:
>
> I'll give this more testing, but it looks ok so far,

Looks fine to me.

I'd perhaps suggest using a simpler interface than
"__get_free_pages(GFP_KERNEL, 0);".

If nothing else, just drop the "order" argument and use
"__get_free_page()", but maybe even just doing "kmalloc/kfree".

               Linus

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] fs/proc/kcore.c: Omit kernel text area for hardened usercopy feature Jiri Olsa <jolsa@kernel.org> - 2016-09-02 14:30 +0200
  Re: [PATCH] fs/proc/kcore.c: Omit kernel text area for hardened  usercopy feature Andi Kleen <andi@firstfloor.org> - 2016-09-02 17:20 +0200
    Re: [PATCH] fs/proc/kcore.c: Omit kernel text area for hardened  usercopy feature Jiri Olsa <jolsa@redhat.com> - 2016-09-02 18:20 +0200
    Re: [PATCH] fs/proc/kcore.c: Omit kernel text area for hardened  usercopy feature Jiri Olsa <jolsa@redhat.com> - 2016-09-05 10:50 +0200
      Re: [PATCH] fs/proc/kcore.c: Omit kernel text area for hardened  usercopy feature Andi Kleen <andi@firstfloor.org> - 2016-09-05 18:30 +0200
      Re: [PATCH] fs/proc/kcore.c: Omit kernel text area for hardened  usercopy feature Kees Cook <keescook@chromium.org> - 2016-09-06 20:00 +0200
        Re: [PATCH] fs/proc/kcore.c: Omit kernel text area for hardened  usercopy feature Linus Torvalds <torvalds@linux-foundation.org> - 2016-09-06 20:40 +0200
          Re: [PATCH] fs/proc/kcore.c: Omit kernel text area for hardened  usercopy feature Andi Kleen <andi@firstfloor.org> - 2016-09-06 21:50 +0200
            Re: [PATCH] fs/proc/kcore.c: Omit kernel text area for hardened  usercopy feature Linus Torvalds <torvalds@linux-foundation.org> - 2016-09-06 21:50 +0200
              Re: [PATCH] fs/proc/kcore.c: Omit kernel text area for hardened  usercopy feature Kees Cook <keescook@chromium.org> - 2016-09-07 19:20 +0200
                Re: [PATCH] fs/proc/kcore.c: Omit kernel text area for hardened  usercopy feature Linus Torvalds <torvalds@linux-foundation.org> - 2016-09-07 19:30 +0200
        Re: [PATCH] fs/proc/kcore.c: Omit kernel text area for hardened  usercopy feature Jiri Olsa <jolsa@redhat.com> - 2016-09-07 09:40 +0200
          Re: [PATCH] fs/proc/kcore.c: Omit kernel text area for hardened  usercopy feature Andi Kleen <andi@firstfloor.org> - 2016-09-07 18:40 +0200
            Re: [PATCH] fs/proc/kcore.c: Omit kernel text area for hardened  usercopy feature Linus Torvalds <torvalds@linux-foundation.org> - 2016-09-07 19:00 +0200
              Re: [PATCH] fs/proc/kcore.c: Omit kernel text area for hardened  usercopy feature Jiri Olsa <jolsa@redhat.com> - 2016-09-07 21:30 +0200
                Re: [PATCH] fs/proc/kcore.c: Omit kernel text area for hardened  usercopy feature Jiri Olsa <jolsa@redhat.com> - 2016-09-07 23:30 +0200
                Re: [PATCH] fs/proc/kcore.c: Omit kernel text area for hardened  usercopy feature Linus Torvalds <torvalds@linux-foundation.org> - 2016-09-08 01:00 +0200

csiph-web