Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1478581
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev |
| Date | 2016-09-07 21:50 +0200 |
| Message-ID | <seR17-44c-3@gated-at.bofh.it> (permalink) |
| References | <seNAe-1Vy-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wednesday, September 7, 2016 12:08:20 PM CEST Alan Stern wrote:
> On Wed, 7 Sep 2016, Arnd Bergmann wrote:
>
> > drivers/usb/host/ehci-fsl.c | 4 ++--
>
> How did this driver end up in the patch?
>
> > diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c
> > index 9f5ffb629973..b2419950221f 100644
> > --- a/drivers/usb/host/ehci-fsl.c
> > +++ b/drivers/usb/host/ehci-fsl.c
> > @@ -96,8 +96,8 @@ static int fsl_ehci_drv_probe(struct platform_device *pdev)
> > }
> > irq = res->start;
> >
> > - hcd = usb_create_hcd(&fsl_ehci_hc_driver, &pdev->dev,
> > - dev_name(&pdev->dev));
> > + hcd = __usb_create_hcd(&fsl_ehci_hc_driver, &pdev->dev.parent,
> > + &pdev->dev, dev_name(&pdev->dev), NULL);
>
> Based on the
>
> if (of_device_is_compatible(dev->parent->of_node,
> "fsl,mpc5121-usb2-dr")) {
>
> lines in the driver?
No, based on the "fsl-ehci" name, which is only used as a child
of the drivers/usb/host/fsl-mph-dr-of.c dual-role driver.
I looked for drivers that call platform_device_add() and manipulate
the dma_mask of that child.
Sorry for missing this one when I did the description. I believe
it is correct though. The DMA settings on powerpc are probably correct
in this case, but the existing code doesn't allow you to describe
on-board USB devices with additional properties as children of
the dual-role device node.
Arnd
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Leo Li <pku.leo@gmail.com> - 2016-09-02 00:20 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Arnd Bergmann <arnd@arndb.de> - 2016-09-02 12:50 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-09-02 13:00 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Felipe Balbi <balbi@kernel.org> - 2016-09-02 13:20 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Felipe Balbi <balbi@kernel.org> - 2016-09-02 16:20 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Alan Stern <stern@rowland.harvard.edu> - 2016-09-02 16:30 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Arnd Bergmann <arnd@arndb.de> - 2016-09-02 18:00 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Roger Quadros <rogerq@ti.com> - 2016-09-07 09:20 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Arnd Bergmann <arnd@arndb.de> - 2016-09-07 10:30 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Roger Quadros <rogerq@ti.com> - 2016-09-07 15:10 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Arnd Bergmann <arnd@arndb.de> - 2016-09-07 16:40 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Grygorii Strashko <grygorii.strashko@ti.com> - 2016-09-02 18:30 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Felipe Balbi <balbi@kernel.org> - 2016-09-02 13:00 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Robin Murphy <robin.murphy@arm.com> - 2016-09-02 14:00 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Felipe Balbi <balbi@kernel.org> - 2016-09-02 15:00 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Arnd Bergmann <arnd@arndb.de> - 2016-09-02 15:20 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Leo Li <pku.leo@gmail.com> - 2016-09-03 00:20 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Arnd Bergmann <arnd@arndb.de> - 2016-09-05 17:50 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Peter Chen <hzpeterchen@gmail.com> - 2016-09-06 08:40 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Felipe Balbi <balbi@kernel.org> - 2016-09-06 08:50 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Arnd Bergmann <arnd@arndb.de> - 2016-09-06 12:50 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Felipe Balbi <balbi@kernel.org> - 2016-09-06 13:00 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Arnd Bergmann <arnd@arndb.de> - 2016-09-06 15:30 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Felipe Balbi <balbi@kernel.org> - 2016-09-07 09:00 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Peter Chen <hzpeterchen@gmail.com> - 2016-09-07 09:50 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Arnd Bergmann <arnd@arndb.de> - 2016-09-07 11:00 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Peter Chen <hzpeterchen@gmail.com> - 2016-09-07 11:30 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-09-07 11:40 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Felipe Balbi <balbi@kernel.org> - 2016-09-07 12:20 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Arnd Bergmann <arnd@arndb.de> - 2016-09-06 12:40 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Peter Chen <hzpeterchen@gmail.com> - 2016-09-07 08:40 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Arnd Bergmann <arnd@arndb.de> - 2016-09-07 10:50 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Peter Chen <hzpeterchen@gmail.com> - 2016-09-07 12:00 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Robin Murphy <robin.murphy@arm.com> - 2016-09-07 12:40 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Felipe Balbi <balbi@kernel.org> - 2016-09-07 12:50 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Felipe Balbi <balbi@kernel.org> - 2016-09-07 12:30 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Arnd Bergmann <arnd@arndb.de> - 2016-09-07 17:30 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Alan Stern <stern@rowland.harvard.edu> - 2016-09-07 18:10 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Arnd Bergmann <arnd@arndb.de> - 2016-09-07 21:50 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Peter Chen <hzpeterchen@gmail.com> - 2016-09-08 03:20 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Arnd Bergmann <arnd@arndb.de> - 2016-09-08 10:10 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Felipe Balbi <balbi@kernel.org> - 2016-09-08 10:10 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Arnd Bergmann <arnd@arndb.de> - 2016-09-08 10:30 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Felipe Balbi <balbi@kernel.org> - 2016-09-08 10:40 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Arnd Bergmann <arnd@arndb.de> - 2016-09-08 10:50 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Felipe Balbi <balbi@kernel.org> - 2016-09-08 11:50 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Arnd Bergmann <arnd@arndb.de> - 2016-09-08 12:20 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Felipe Balbi <balbi@kernel.org> - 2016-09-08 13:10 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Arnd Bergmann <arnd@arndb.de> - 2016-09-08 13:20 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Felipe Balbi <balbi@kernel.org> - 2016-09-08 13:30 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Arnd Bergmann <arnd@arndb.de> - 2016-09-08 13:50 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Felipe Balbi <balbi@kernel.org> - 2016-09-08 14:00 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Arnd Bergmann <arnd@arndb.de> - 2016-09-08 14:50 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Grygorii Strashko <grygorii.strashko@ti.com> - 2016-09-08 14:10 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Arnd Bergmann <arnd@arndb.de> - 2016-09-08 14:20 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Peter Chen <hzpeterchen@gmail.com> - 2016-09-08 14:30 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Arnd Bergmann <arnd@arndb.de> - 2016-09-08 15:00 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Peter Chen <hzpeterchen@gmail.com> - 2016-09-09 03:40 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Grygorii Strashko <grygorii.strashko@ti.com> - 2016-09-08 15:10 +0200
Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Peter Chen <hzpeterchen@gmail.com> - 2016-09-09 04:00 +0200
csiph-web