Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1478493

Re: linux-next: Tree for Sep 7 (kernel/trace/trace_hwlat.c)

Show all headers | View raw

On Wed, 7 Sep 2016 09:37:00 -0700
Randy Dunlap <rdunlap@infradead.org> wrote:

> On 09/07/16 00:52, Stephen Rothwell wrote:
> > Hi all,
> > 
> > Changes since 20160906:
> >   
> 
> on i386:
> 
> ../kernel/trace/trace_hwlat.c: In function 'get_sample':
> ../kernel/trace/trace_hwlat.c:258:18: error: 'struct trace_array' has no member named 'max_latency'
>    if (sample > tr->max_latency)
>                   ^
> ../kernel/trace/trace_hwlat.c:259:6: error: 'struct trace_array' has no member named 'max_latency'
>     tr->max_latency = sample;
>       ^
> ../kernel/trace/trace_hwlat.c: In function 'hwlat_tracer_init':
> ../kernel/trace/trace_hwlat.c:583:4: error: 'struct trace_array' has no member named 'max_latency'
>   tr->max_latency = 0;
>     ^
> 
> when CONFIG_TRACER_MAX_TRACE is not enabled.
> 

Thanks!

Below is the fix. I'll have to add it.

-- Steve


diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
index 72c07c2ffd79..d9000a81960e 100644
--- a/kernel/trace/Kconfig
+++ b/kernel/trace/Kconfig
@@ -224,6 +224,7 @@ config SCHED_TRACER
 config HWLAT_TRACER
 	bool "Tracer to detect hardware latencies (like SMIs)"
 	select GENERIC_TRACER
+	select TRACER_MAX_TRACE
 	help
 	 This tracer, when enabled will create one or more kernel threads,
 	 depening on what the cpumask file is set to, which each thread

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

linux-next: Tree for Sep 7 Stephen Rothwell <sfr@canb.auug.org.au> - 2016-09-07 10:00 +0200
  Re: linux-next: Tree for Sep 7 (kernel/trace/trace_hwlat.c) Randy Dunlap <rdunlap@infradead.org> - 2016-09-07 18:40 +0200
    Re: linux-next: Tree for Sep 7 (kernel/trace/trace_hwlat.c) Steven Rostedt <rostedt@goodmis.org> - 2016-09-07 18:50 +0200
      Re: linux-next: Tree for Sep 7 (kernel/trace/trace_hwlat.c) Randy Dunlap <rdunlap@infradead.org> - 2016-09-07 20:40 +0200
        Re: linux-next: Tree for Sep 7 (kernel/trace/trace_hwlat.c) Steven Rostedt <rostedt@goodmis.org> - 2016-09-07 20:50 +0200
          Re: linux-next: Tree for Sep 7 (kernel/trace/trace_hwlat.c) Steven Rostedt <rostedt@goodmis.org> - 2016-09-07 21:40 +0200
            Re: linux-next: Tree for Sep 7 (kernel/trace/trace_hwlat.c) Randy Dunlap <rdunlap@infradead.org> - 2016-09-07 23:00 +0200
              Re: linux-next: Tree for Sep 7 (kernel/trace/trace_hwlat.c) Steven Rostedt <rostedt@goodmis.org> - 2016-09-08 05:00 +0200
                Re: linux-next: Tree for Sep 7 (kernel/trace/trace_hwlat.c) Randy Dunlap <rdunlap@infradead.org> - 2016-09-08 08:50 +0200
            Re: linux-next: Tree for Sep 7 (kernel/trace/trace_hwlat.c) Stephen Rothwell <sfr@canb.auug.org.au> - 2016-09-07 23:50 +0200
              Re: linux-next: Tree for Sep 7 (kernel/trace/trace_hwlat.c) Steven Rostedt <rostedt@goodmis.org> - 2016-09-08 05:00 +0200

csiph-web