Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1478439

RE: [patch] leds: add driver for Mellanox systems leds

Show all headers | View raw

Hi Jacek,

Thank you for your comments.

> -----Original Message-----
> From: Jacek Anaszewski [mailto:j.anaszewski@samsung.com]
> Sent: Wednesday, September 07, 2016 3:49 PM
> To: Vadim Pasternak <vadimp@mellanox.com>; rpurdie@rpsys.net
> Cc: linux-leds@vger.kernel.org; linux-kernel@vger.kernel.org; jiri@resnulli.us;
> Michael Shych <michaelsh@mellanox.com>
> Subject: Re: [patch] leds: add driver for Mellanox systems leds
> 
> Hi Vadim,
> 
> On 09/07/2016 03:35 PM, vadimp@mellanox.com wrote:
> > From: Vadim Pasternak <vadimp@mellanox.com>
> >
> > This makes it possible to create a set of LEDs for Mellanox systems:
> > "msx6710", "msx6720", "msb7700", "msn2700", "msx1410", "msn2410",
> > "msb7800", "msn2740", "msn2100".
> >
> > Driver obtains led devices according to system configuration, provided
> > through system DMI data, like fan1:green, fan1:red and creates devices
> > in
> > form: "devicename:colour:function".
> >
> > led setting is controlled through on board CPLD Lattice device.
> > For setting particular led off, solid, blink (blink requires
> > ledtrig-timer module):
> > echo 0 > /sys/class/leds/status\:green/brightness
> > echo 1 > /sys/class/leds/status\:green/brightness
> > echo timer > /sys/class/leds/status\:green/trigger
> >
> 
> Thanks for the update, will review it soon.
> 
> One important detail - please update patch version each time you're sending a
> new one, like [PATCH v2].
> 
Will do it in this format next time.
Thanks for this input.
Best regards,
Vadim.

> --
> Best regards,
> Jacek Anaszewski

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[patch] leds: add driver for Mellanox systems leds vadimp@mellanox.com - 2016-09-07 13:40 +0200
  RE: [patch] leds: add driver for Mellanox systems leds Vadim Pasternak <vadimp@mellanox.com> - 2016-09-07 14:40 +0200
  Re: [patch] leds: add driver for Mellanox systems leds Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-09-07 14:50 +0200
    Re: [patch] leds: add driver for Mellanox systems leds Jiri Pirko <jiri@resnulli.us> - 2016-09-07 15:00 +0200
    RE: [patch] leds: add driver for Mellanox systems leds Vadim Pasternak <vadimp@mellanox.com> - 2016-09-07 17:40 +0200
  Re: [patch] leds: add driver for Mellanox systems leds "Dr. David Alan Gilbert" <dave@treblig.org> - 2016-09-07 14:50 +0200

csiph-web