Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1478340

Re: [PATCH v4 0/5] kexec_file: Add buffer hand-over for the next kernel

Show all headers | View raw

ebiederm@xmission.com (Eric W. Biederman) writes:

> Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com> writes:
>
>> Hello,
>>
>> The purpose of this new version of the series is to fix a small issue that
>> I found, which is that the kernel doesn't remove the memory reservation
>> for the hand-over buffer it received from the previous kernel in the
>> device tree it sets up for the next kernel. The result is that for each
>> successive kexec, a stale hand-over buffer is left behind, wasting memory.
>>
>> This is fixed by changes to kexec_free_handover_buffer and
>> setup_handover_buffer in patch 2. The other change is to fix checkpatch
>> warnings in the last patch.
>
> This is fundamentally broken.  You do not increase the integrity of a
> system by dropping integrity checks.
>
> No. No. No. No.
>
> Nacked-by: "Eric W. Biederman" <ebiederm@xmission.com>

To be constructive the way we have handled similiar situations in the
past (hotplu memory) is to call kexec_load again.

Eric

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 0/5] kexec_file: Add buffer hand-over for the next kernel Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com> - 2016-08-30 19:50 +0200
  [PATCH v4 1/5] kexec_file: Add buffer hand-over support for the next kernel Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com> - 2016-08-30 19:50 +0200
  [PATCH v4 4/5] kexec_file: Add mechanism to update kexec segments. Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com> - 2016-08-30 19:50 +0200
  [PATCH v4 3/5] kexec_file: Allow skipping checksum calculation for some segments. Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com> - 2016-08-30 19:50 +0200
    Re: [PATCH v4 3/5] kexec_file: Allow skipping checksum calculation for some segments. ebiederm@xmission.com (Eric W. Biederman) - 2016-09-07 03:50 +0200
  [PATCH v4 5/5] IMA: Demonstration code for kexec buffer passing. Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com> - 2016-08-30 19:50 +0200
  Re: [PATCH v4 0/5] kexec_file: Add buffer hand-over for the next kernel ebiederm@xmission.com (Eric W. Biederman) - 2016-09-07 16:40 +0200
    Re: [PATCH v4 0/5] kexec_file: Add buffer hand-over for the next kernel Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com> - 2016-09-08 21:30 +0200
      Re: [PATCH v4 0/5] kexec_file: Add buffer hand-over for the next kernel ebiederm@xmission.com (Eric W. Biederman) - 2016-09-09 06:30 +0200
        Re: [PATCH v4 0/5] kexec_file: Add buffer hand-over for the next  kernel Mimi Zohar <zohar@linux.vnet.ibm.com> - 2016-09-09 15:10 +0200
  Re: [PATCH v4 0/5] kexec_file: Add buffer hand-over for the next kernel ebiederm@xmission.com (Eric W. Biederman) - 2016-09-07 17:50 +0200

csiph-web