Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1478319

Re: [PATCH net-next 0/3] r8152: configuration setting

Show all headers | View raw

[ CCing Oliver, who AFAIK still is the cdc_ether maintainer and should
  have the final word on this ]

Hayes Wang <hayeswang@realtek.com> writes:

> Some people prefer to use ECM mode rather than vendor mode. Therefore, I add
> CONFIG_RTL8152_CONFIG_VALUE in Kconfig. Then, the users could choose the USB
> configuration value which they want. The default is to support vendor mode
> only.
>
> Hayes Wang (3):
>   r8152: check hw version first
>   r8152: support ECM mode
>   r8152: add CONFIG_RTL8152_CONFIG_VALUE
>
>  drivers/net/usb/Kconfig |  13 ++
>  drivers/net/usb/r8152.c | 383 +++++++++++++++++++++++++++++++++++++++++-------
>  2 files changed, 345 insertions(+), 51 deletions(-)


So this adds a lot of code to work around the issues you introduced by
unnecessarily blacklisting the CDC ECM configuration earlier, and still
makes the r8152 driver handle the device even in ECM mode.

Sorry, but this is a total mess.

Just remove the completely unnecessary blacklist, and let the cdc_ether
driver handle the device if the user selects the ECM configuration.
That't how the USB system works.  There is no need for any code in r8152
to do that.

Ref https://lkml.org/lkml/2014/1/3/57



Bjørn

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next 0/3] r8152: configuration setting Hayes Wang <hayeswang@realtek.com> - 2016-09-07 10:20 +0200
  [PATCH net-next 2/3] r8152: support ECM mode Hayes Wang <hayeswang@realtek.com> - 2016-09-07 10:20 +0200
  Re: [PATCH net-next 0/3] r8152: configuration setting Bjørn Mork <bjorn@mork.no> - 2016-09-07 16:00 +0200
    RE: [PATCH net-next 0/3] r8152: configuration setting Hayes Wang <hayeswang@realtek.com> - 2016-09-08 04:50 +0200
      Re: [PATCH net-next 0/3] r8152: configuration setting Bjørn Mork <bjorn@mork.no> - 2016-09-08 10:00 +0200
        RE: [PATCH net-next 0/3] r8152: configuration setting Hayes Wang <hayeswang@realtek.com> - 2016-09-08 15:10 +0200
          Re: [PATCH net-next 0/3] r8152: configuration setting Bjørn Mork <bjorn@mork.no> - 2016-09-08 15:20 +0200
          Re: [PATCH net-next 0/3] r8152: configuration setting Oliver Neukum <oneukum@suse.com> - 2016-09-08 15:20 +0200
  Re: [PATCH net-next 0/3] r8152: configuration setting David Miller <davem@davemloft.net> - 2016-09-08 02:40 +0200
    RE: [PATCH net-next 0/3] r8152: configuration setting Hayes Wang <hayeswang@realtek.com> - 2016-09-08 05:10 +0200

csiph-web