Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1478330

Re: [PATCH V2 9/9] i2c: tegra: Add pinctrl support

Show all headers | View raw

On Fri, Aug 26, 2016 at 3:09 PM, Jon Hunter <jonathanh@nvidia.com> wrote:

> On Tegra124/132 the pins for I2C6 are shared with the Display Port AUX
> (DPAUX) channel and on Tegra210 the pins for I2C4 and I2C6 are shared
> with DPAUX1 and DPAUX0, respectively. The multiplexing of the pins is
> handled by a register in the DPAUX and so the Tegra DPAUX driver has
> been updated to register a pinctrl device for managing these pins.
>
> The pins for these particular I2C devices are bound to the I2C device
> prior to probing. However, these I2C devices are in a different power
> partition to the DPAUX devices that own the pins. Hence, it is desirable
> to place the pins in the 'idle' state and allow the DPAUX power
> partition to switch off, when these I2C devices is not in use.
> Therefore, add calls to place the I2C pins in the 'default' and 'idle'
> states when the I2C device is runtime resumed and suspended,
> respectively.
>
> Please note that the pinctrl functions that set the state of the pins
> check to see if the devices has pins associated and will return zero
> if they do not. Therefore, it is safe to call these pinctrl functions
> even for I2C devices that do not have any pins associated.
>
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> Acked-by: Laxman Dewangan <ldewangan@nvidia.com>

This is exactly how I imagined these states being used,
so obviously:
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH V2 0/9] Some Tegra I2C Updates Jon Hunter <jonathanh@nvidia.com> - 2016-08-26 15:10 +0200
  [PATCH V2 5/9] i2c: tegra: Remove non device-tree support Jon Hunter <jonathanh@nvidia.com> - 2016-08-26 15:10 +0200
  [PATCH V2 2/9] i2c: tegra: Use BIT macro Jon Hunter <jonathanh@nvidia.com> - 2016-08-26 15:10 +0200
  [PATCH V2 1/9] i2c: tegra: Fix lines over 80 characters Jon Hunter <jonathanh@nvidia.com> - 2016-08-26 15:10 +0200
  [PATCH V2 8/9] i2c: tegra: Add runtime power-management support Jon Hunter <jonathanh@nvidia.com> - 2016-08-26 15:20 +0200
  [PATCH V2 9/9] i2c: tegra: Add pinctrl support Jon Hunter <jonathanh@nvidia.com> - 2016-08-26 15:20 +0200
    Re: [PATCH V2 9/9] i2c: tegra: Add pinctrl support Stephen Warren <swarren@wwwdotorg.org> - 2016-08-26 18:00 +0200
      Re: [PATCH V2 9/9] i2c: tegra: Add pinctrl support Jon Hunter <jonathanh@nvidia.com> - 2016-08-26 18:50 +0200
        Re: [PATCH V2 9/9] i2c: tegra: Add pinctrl support Stephen Warren <swarren@wwwdotorg.org> - 2016-08-26 19:10 +0200
    Re: [PATCH V2 9/9] i2c: tegra: Add pinctrl support Linus Walleij <linus.walleij@linaro.org> - 2016-09-07 16:20 +0200
  [PATCH V2 6/9] i2c: tegra: Use device name for adapter name Jon Hunter <jonathanh@nvidia.com> - 2016-08-26 15:20 +0200
  [PATCH V2 4/9] i2c: tegra: Add missing new line characters Jon Hunter <jonathanh@nvidia.com> - 2016-08-26 15:20 +0200
  [PATCH V2 7/9] i2c: tegra: Simplify I2C resume Jon Hunter <jonathanh@nvidia.com> - 2016-08-26 15:20 +0200
  Re: [PATCH V2 0/9] Some Tegra I2C Updates Wolfram Sang <wsa@the-dreams.de> - 2016-08-26 18:00 +0200
    Re: [PATCH V2 0/9] Some Tegra I2C Updates Jon Hunter <jonathanh@nvidia.com> - 2016-08-26 18:50 +0200
  Re: [PATCH V2 0/9] Some Tegra I2C Updates Wolfram Sang <wsa@the-dreams.de> - 2016-08-30 22:40 +0200
    Re: [PATCH V2 0/9] Some Tegra I2C Updates Jon Hunter <jonathanh@nvidia.com> - 2016-09-06 12:00 +0200

csiph-web