Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1478299

Re: Question on smp_mb__before_spinlock

Show all headers | View raw

On Wed, Sep 07, 2016 at 10:17:26PM +1000, Nicholas Piggin wrote:
> >  /*
> > + * This barrier must provide two things:
> > + *
> > + *   - it must guarantee a STORE before the spin_lock() is ordered against a
> > + *     LOAD after it, see the comments at its two usage sites.
> > + *
> > + *   - it must ensure the critical section is RCsc.
> > + *
> > + * The latter is important for cases where we observe values written by other
> > + * CPUs in spin-loops, without barriers, while being subject to scheduling.
> > + *
> > + * CPU0			CPU1			CPU2
> > + * 
> > + * 			for (;;) {
> > + * 			  if (READ_ONCE(X))
> > + * 			  	break;
> > + * 			}
> > + * X=1
> > + * 			<sched-out>
> > + * 						<sched-in>
> > + * 						r = X;
> > + *
> > + * without transitivity it could be that CPU1 observes X!=0 breaks the loop,
> > + * we get migrated and CPU2 sees X==0.
> > + *
> > + * Since most load-store architectures implement ACQUIRE with an smp_mb() after
> > + * the LL/SC loop, they need no further barriers. Similarly all our TSO
> > + * architectures imlpy an smp_mb() for each atomic instruction and equally don't
> > + * need more.
> > + *
> > + * Architectures that can implement ACQUIRE better need to take care.
> >   */
> > +#ifndef smp_mb__after_spinlock
> > +#define smp_mb__after_spinlock()	do { } while (0)
> >  #endif
> 
> It seems okay, but why not make it a special sched-only function name
> to prevent it being used in generic code?
> 
> I would not mind seeing responsibility for the switch barrier moved to
> generic context switch code like this (alternative for powerpc reducing
> number of hwsync instructions was to add documentation and warnings about
> the barriers in arch dependent and independent code). And pairing it with
> a spinlock is reasonable.
> 
> It may not strictly be an "smp_" style of barrier if MMIO accesses are to
> be ordered here too, despite critical section may only be providing
> acquire/release for cacheable memory, so maybe it's slightly more
> complicated than just cacheable RCsc?

Interesting idea..

So I'm not a fan of that raw_spin_lock wrapper, since that would end up
with a lot more boiler-plate code than just the one extra barrier.

But moving MMIO/DMA/TLB etc.. barriers into this spinlock might not be a
good idea, since those are typically fairly heavy barriers, and its
quite common to call schedule() without ending up in switch_to().

For PowerPC it works out, since there's only SYNC, no other option
afaik.

But ARM/ARM64 will have to do DSB(ISH) instead of DMB(ISH). IA64 would
need to issue "sync.i" and mips-octeon "synciobdma".

Will, any idea of the extra cost involved in DSB vs DMB?

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Question on smp_mb__before_spinlock Peter Zijlstra <peterz@infradead.org> - 2016-09-05 11:40 +0200
  Re: Question on smp_mb__before_spinlock kbuild test robot <lkp@intel.com> - 2016-09-05 12:00 +0200
    Re: Question on smp_mb__before_spinlock Peter Zijlstra <peterz@infradead.org> - 2016-09-05 12:20 +0200
      Re: Question on smp_mb__before_spinlock Fengguang Wu <lkp@intel.com> - 2016-09-05 13:30 +0200
  Re: Question on smp_mb__before_spinlock Will Deacon <will.deacon@arm.com> - 2016-09-05 12:20 +0200
    Re: Question on smp_mb__before_spinlock Peter Zijlstra <peterz@infradead.org> - 2016-09-06 13:20 +0200
      Re: Question on smp_mb__before_spinlock Will Deacon <will.deacon@arm.com> - 2016-09-06 19:50 +0200
  Re: Question on smp_mb__before_spinlock "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-09-05 12:40 +0200
    Re: Question on smp_mb__before_spinlock Peter Zijlstra <peterz@infradead.org> - 2016-09-05 13:40 +0200
      Re: Question on smp_mb__before_spinlock "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-09-05 16:00 +0200
  Re: Question on smp_mb__before_spinlock Nicholas Piggin <npiggin@gmail.com> - 2016-09-07 14:20 +0200
    Re: Question on smp_mb__before_spinlock Peter Zijlstra <peterz@infradead.org> - 2016-09-07 15:30 +0200
      Re: Question on smp_mb__before_spinlock Will Deacon <will.deacon@arm.com> - 2016-09-07 16:00 +0200

csiph-web