Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1478257

RE: [PATCH] qed: add missing header dependencies

Show all headers | View raw

> > While I obviously have no strong objection for including
> > qed_selftest.h from qed_selftest.c, I'm not sure I understand which C
> > standard dictates this requirement.
> > Why should a function definition [not call] be preceded by a prototype?
> 
> - When a function is defined in one file and used in another, you want
>   both files to include the same header that has the declaration to
>   ensure that the types are identical. There are cases where the
>   prototype is changed after the fact in an incompatible way, causing
>   silent data corruption on some configurations but maybe not on others.

O.k., motivation is clear.
But this really isn't enforced by the ansi-c standard, right?

Anyway, thanks.

Acked-by: Yuval Mintz <Yuval.Mintz@qlogic.com>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] qed: add missing header dependencies Baoyou Xie <baoyou.xie@linaro.org> - 2016-09-07 13:10 +0200
  RE: [PATCH] qed: add missing header dependencies Yuval Mintz <Yuval.Mintz@qlogic.com> - 2016-09-07 14:00 +0200
    Re: [PATCH] qed: add missing header dependencies Arnd Bergmann <arnd@arndb.de> - 2016-09-07 14:20 +0200
      RE: [PATCH] qed: add missing header dependencies Yuval Mintz <Yuval.Mintz@qlogic.com> - 2016-09-07 14:50 +0200
        Re: [PATCH] qed: add missing header dependencies Arnd Bergmann <arnd@arndb.de> - 2016-09-07 15:00 +0200
  Re: [PATCH] qed: add missing header dependencies David Miller <davem@davemloft.net> - 2016-09-08 02:50 +0200

csiph-web