Re: [PATCH] power: supply: sbs-battery: simplify DT parsing

From	Sebastian Reichel <sre@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] power: supply: sbs-battery: simplify DT parsing
Date	2016-09-07 15:20 +0200
Message-ID	<seKVI-db-35@gated-at.bofh.it> (permalink)
References	<seos9-2uF-27@gated-at.bofh.it> <seyrv-oi-1@gated-at.bofh.it> <seFW2-5g7-35@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

On Wed, Sep 07, 2016 at 09:58:10AM +0200, Arnd Bergmann wrote:
> On Wednesday, September 7, 2016 1:55:23 AM CEST Sebastian Reichel wrote:
> > 
> > Patch looks fine to me. Actually I already asked Phil to
> > implement your change [0]. I just queued it to power-supply's
> > for-next branch.
> > 
> > [0] https://marc.info/?l=linux-pm&m=147273382018953&w=2
> 
> Glad to see we had the same thought. ;-)
> 
> I see that we went for different defaults for chip->poll_retry_count:
> I concluded that '0' would be the correct default, while you suggested '1'
> in your reply.
> 
> Can you double-check the code and see which one is right?

0 is correct. It will be incremented to 1 later.

-- Sebastian

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] power: supply: sbs-battery: simplify DT parsing Arnd Bergmann <arnd@arndb.de> - 2016-09-06 15:20 +0200
  Re: [PATCH] power: supply: sbs-battery: simplify DT parsing Sebastian Reichel <sre@kernel.org> - 2016-09-07 02:00 +0200
    Re: [PATCH] power: supply: sbs-battery: simplify DT parsing Arnd Bergmann <arnd@arndb.de> - 2016-09-07 10:00 +0200
      Re: [PATCH] power: supply: sbs-battery: simplify DT parsing Sebastian Reichel <sre@kernel.org> - 2016-09-07 15:20 +0200

csiph-web