Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1478275

Re: [PATCH] crypto: qce: Initialize core src clock @100Mhz

Show all headers | View raw

Hi Iaroslav,

On 09/03/2016 07:45 PM, Iaroslav Gridin wrote:
> Without that, QCE performance is about 2x less.

On which platform? The clock rates are per SoC.

> 
> Signed-off-by: Iaroslav Gridin <voker57@gmail.com>
> ---
>  drivers/crypto/qce/core.c | 18 +++++++++++++++++-
>  drivers/crypto/qce/core.h |  2 +-
>  2 files changed, 18 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/crypto/qce/core.c b/drivers/crypto/qce/core.c
> index 0cde513..657354c 100644
> --- a/drivers/crypto/qce/core.c
> +++ b/drivers/crypto/qce/core.c
> @@ -193,6 +193,10 @@ static int qce_crypto_probe(struct platform_device *pdev)
>  	if (ret < 0)
>  		return ret;
>  
> +	qce->core_src = devm_clk_get(qce->dev, "core_src");
> +	if (IS_ERR(qce->core_src))
> +		return PTR_ERR(qce->core_src);
> +
>  	qce->core = devm_clk_get(qce->dev, "core");
>  	if (IS_ERR(qce->core))
>  		return PTR_ERR(qce->core);
> @@ -205,10 +209,20 @@ static int qce_crypto_probe(struct platform_device *pdev)
>  	if (IS_ERR(qce->bus))
>  		return PTR_ERR(qce->bus);
>  
> -	ret = clk_prepare_enable(qce->core);
> +	ret = clk_prepare_enable(qce->core_src);
>  	if (ret)
>  		return ret;
>  
> +	ret = clk_set_rate(qce->core_src, 100000000);

Could you point me from where you got this number? Also I think you
shouldn't be requesting "core_src" it should be a parent of "core" clock
in the clock tree. Did you tried to set rate on "core" clock?

regards,
Stan

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] crypto: qce: Initialize core src clock @100Mhz Iaroslav Gridin <voker57@gmail.com> - 2016-09-03 18:50 +0200
  Re: [PATCH] crypto: qce: Initialize core src clock @100Mhz Herbert Xu <herbert@gondor.apana.org.au> - 2016-09-07 15:00 +0200
  Re: [PATCH] crypto: qce: Initialize core src clock @100Mhz Stanimir Varbanov <svarbanov@mm-sol.com> - 2016-09-07 15:10 +0200
    Re: [PATCH] crypto: qce: Initialize core src clock @100Mhz Iaroslav Gridin <voker57@gmail.com> - 2016-09-07 18:20 +0200
    Re: [PATCH] crypto: qce: Initialize core src clock @100Mhz Iaroslav Gridin <voker57@gmail.com> - 2016-09-07 19:30 +0200

csiph-web