Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1478215
| From | Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 4/5] gpio: pca953x: remove an unused variable |
| Date | 2016-09-07 13:40 +0200 |
| Message-ID | <seJmW-7z9-27@gated-at.bofh.it> (permalink) |
| References | <seHl7-6jf-3@gated-at.bofh.it> <seHl8-6jf-21@gated-at.bofh.it> |
| Organization | Intel Finland Oy |
On Wed, 2016-09-07 at 11:24 +0200, Bartosz Golaszewski wrote:
> The chip_type variable in struct pca953x_chip is no longer required.
>
> Remove it.
Would it be patch 4 in the series?
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
> drivers/gpio/gpio-pca953x.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
> index 6b62898..00bb2ea 100644
> --- a/drivers/gpio/gpio-pca953x.c
> +++ b/drivers/gpio/gpio-pca953x.c
> @@ -129,7 +129,6 @@ struct pca953x_chip {
> struct i2c_client *client;
> struct gpio_chip gpio_chip;
> const char *const *names;
> - int chip_type;
> unsigned long driver_data;
>
> const struct pca953x_offset *offset;
> @@ -760,8 +759,6 @@ static int pca953x_probe(struct i2c_client
> *client,
> }
> }
>
> - chip->chip_type = PCA_CHIP_TYPE(chip->driver_data);
> -
> mutex_init(&chip->i2c_lock);
>
> /* initialize cached registers from their original values.
> @@ -774,7 +771,7 @@ static int pca953x_probe(struct i2c_client
> *client,
> else if (chip->gpio_chip.ngpio >= 24)
> chip->write_regs = pca953x_write_regs_24;
>
> - if (chip->chip_type == PCA953X_TYPE)
> + if (PCA_CHIP_TYPE(chip->driver_data) == PCA953X_TYPE)
> ret = device_pca953x_init(chip, invert);
> else
> ret = device_pca957x_init(chip, invert);
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 4/5] gpio: pca953x: remove an unused variable Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2016-09-07 11:30 +0200
Re: [PATCH v2 4/5] gpio: pca953x: remove an unused variable Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-09-07 13:40 +0200
Re: [PATCH v2 4/5] gpio: pca953x: remove an unused variable Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2016-09-07 13:50 +0200
Re: [PATCH v2 4/5] gpio: pca953x: remove an unused variable Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-09-07 14:20 +0200
csiph-web