Re: [PATCH v2] usb: gadget: configfs: log function unbinding as debug

From	Felipe Balbi <balbi@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] usb: gadget: configfs: log function unbinding as debug
Date	2016-09-07 12:50 +0200
Message-ID	<seIAx-72R-1@gated-at.bofh.it> (permalink)
References	<rZdoZ-4i9-25@gated-at.bofh.it> <sbqJQ-5oR-31@gated-at.bofh.it> <seHEt-6pC-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Romain Izard <romain.izard.pro@gmail.com> writes:

> 2016-08-29 11:07 GMT+02:00 Romain Izard <romain.izard.pro@gmail.com>:
>> Disabling USB gadget functions configured through configfs is something
>> that can happen in normal use cases. Keep the existing log for this type
>> of event, but only as debug, not as an error.
>>
>> Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>
>> ---
>> v1 -> v2:
>> - use dev_dbg instead of dev_info
>>
>>  drivers/usb/gadget/configfs.c | 5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c
>> index f9237fe2be05..3984787f8e97 100644
>> --- a/drivers/usb/gadget/configfs.c
>> +++ b/drivers/usb/gadget/configfs.c
>> @@ -1211,8 +1211,9 @@ static void purge_configs_funcs(struct gadget_info *gi)
>>
>>                         list_move_tail(&f->list, &cfg->func_list);
>>                         if (f->unbind) {
>> -                               dev_err(&gi->cdev.gadget->dev, "unbind function"
>> -                                               " '%s'/%p\n", f->name, f);
>> +                               dev_dbg(&gi->cdev.gadget->dev,
>> +                                        "unbind function '%s'/%p\n",
>> +                                        f->name, f);
>>                                 f->unbind(c, f);
>>                         }
>>                 }
>> --
>> 2.7.4
>>
>
> Ping ?

https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?h=testing/next&id=da7b895d518cc1753ee5f4b7f2158087282d1a65

-- 
balbi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] usb: gadget: configfs: log function unbinding as debug Romain Izard <romain.izard.pro@gmail.com> - 2016-08-29 11:10 +0200
  Re: [PATCH v2] usb: gadget: configfs: log function unbinding as debug Romain Izard <romain.izard.pro@gmail.com> - 2016-09-07 11:50 +0200
    Re: [PATCH v2] usb: gadget: configfs: log function unbinding as debug Felipe Balbi <balbi@kernel.org> - 2016-09-07 12:50 +0200

csiph-web