Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1476574

Re: [PATCH v8 15/18] ARM: STi: DT: STiH407: Add uniperif reader dt nodes

From Lee Jones <lee.jones@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH v8 15/18] ARM: STi: DT: STiH407: Add uniperif reader dt nodes
Date 2016-09-05 17:50 +0200
Message-ID <se4jM-5El-5@gated-at.bofh.it> (permalink)
References (1 earlier) <saqLU-8tm-35@gated-at.bofh.it> <sbO9r-3ob-1@gated-at.bofh.it> <sbSd4-64E-15@gated-at.bofh.it> <scbSr-1Nd-43@gated-at.bofh.it> <se1cd-3Hh-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, 05 Sep 2016, Arnaud Pouliquen wrote:
> >>>> +			dai-name = "Uni Reader #0 (PCM IN)";
> >>>
> >>> Oooo, not seen something like this before.
> >>>
> >>> If it does not already have one, it would require a DT Ack.
> >>
> >> No idea, the driver got merged 1 year ago.
> This field could be suppressed and handled in source code, using
> st,uniperiph-id to retreive it.

That would be better.

> >> Arnaud did you get a DT ack when you merged this driver & binding? i if i remember well, i had  sent to Alsa mailing list only, I missed
> this obvious...

I'm surprised Mark didn't notice this.

He's usually pretty good at picking stuff like that up.

> >>>> +			st,version = <3>;
> >>>
> >>> This will likely need a DT Ack too.  We usually encode this sort of
> >>> information in the compatible string.
> yes, better to use compatibility
> >>
> >> See 05c1b4480e86a871b18030d6f3d532dc0ecdf38c
> > 
> > Well Rob's the boss.  We certainly never used to take 'device ID' or
> > 'version' attributes.  I guess something must have changed.
> 
> I will try to provide patches for code and bindings rework this week.

Wonderful.. Thanks Arnaud.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH v8 15/18] ARM: STi: DT: STiH407: Add uniperif reader dt nodes Peter Griffin <peter.griffin@linaro.org> - 2016-08-26 17:00 +0200
  Re: [PATCH v8 15/18] ARM: STi: DT: STiH407: Add uniperif reader dt  nodes Lee Jones <lee.jones@linaro.org> - 2016-08-30 12:10 +0200
    Re: [PATCH v8 15/18] ARM: STi: DT: STiH407: Add uniperif reader dt  nodes Peter Griffin <peter.griffin@linaro.org> - 2016-08-30 16:30 +0200
      Re: [PATCH v8 15/18] ARM: STi: DT: STiH407: Add uniperif reader dt  nodes Lee Jones <lee.jones@linaro.org> - 2016-08-31 13:30 +0200
        Re: [PATCH v8 15/18] ARM: STi: DT: STiH407: Add uniperif reader dt  nodes Arnaud Pouliquen <arnaud.pouliquen@st.com> - 2016-09-05 14:30 +0200
          Re: [PATCH v8 15/18] ARM: STi: DT: STiH407: Add uniperif reader dt  nodes Lee Jones <lee.jones@linaro.org> - 2016-09-05 17:50 +0200

csiph-web