Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1476471

Re: [PATCH] arm64/efi: efi_init error handling fix

Show all headers | View raw

On Fri, 02 Sep, at 11:26:18AM, Will Deacon wrote:
> On Fri, Sep 02, 2016 at 06:18:39PM +0800, Xie Yisheng wrote:
> > From: Yisheng Xie <xieyisheng1@huawei.com>
> > 
> > There's an early memmap leak in efi_init error path, fix it.
> > 
> > Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>
> > ---
> >  drivers/firmware/efi/arm-init.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> Adding linux-efi, Ard and Matt. Please try to CC the relevant people in
> future.
> 
> Will
> 
> > diff --git a/drivers/firmware/efi/arm-init.c b/drivers/firmware/efi/arm-init.c
> > index c49d50e..5080e40 100644
> > --- a/drivers/firmware/efi/arm-init.c
> > +++ b/drivers/firmware/efi/arm-init.c
> > @@ -243,8 +243,10 @@ void __init efi_init(void)
> >  	     "Unexpected EFI_MEMORY_DESCRIPTOR version %ld",
> >  	      efi.memmap.desc_version);
> >  
> > -	if (uefi_init() < 0)
> > +	if (uefi_init() < 0) {
> > +		early_memunmap(efi.memmap.map, params.mmap_size);
> >  		return;
> > +	}

This should be a call to efi_memmap_unmap() because the EFI_MEMMAP
flag also needs clearing.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] arm64/efi: efi_init error handling fix Xie Yisheng <xieyisheng1@huawei.com> - 2016-09-02 12:30 +0200
  Re: [PATCH] arm64/efi: efi_init error handling fix Will Deacon <will.deacon@arm.com> - 2016-09-02 12:30 +0200
    Re: [PATCH] arm64/efi: efi_init error handling fix Yisheng Xie <xieyisheng1@huawei.com> - 2016-09-05 13:20 +0200
    Re: [PATCH] arm64/efi: efi_init error handling fix Matt Fleming <matt@codeblueprint.co.uk> - 2016-09-05 16:00 +0200
      Re: [PATCH] arm64/efi: efi_init error handling fix Yisheng Xie <xieyisheng1@huawei.com> - 2016-09-07 13:30 +0200

csiph-web