Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1476404
| From | David Oberhollenzer <david.oberhollenzer@sigma-star.at> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2] ubifs: compress lines for immediate return |
| Date | 2016-09-05 15:20 +0200 |
| Message-ID | <se1YC-4eB-9@gated-at.bofh.it> (permalink) |
| References | <sdW2R-aj-7@gated-at.bofh.it> |
| Organization | sigma star gmbh |
On 09/05/2016 08:54 AM, Heiko Schocher wrote:
> diff --git a/fs/ubifs/budget.c b/fs/ubifs/budget.c
> index 11a11b3..48d6851 100644
> --- a/fs/ubifs/budget.c
> +++ b/fs/ubifs/budget.c
> @@ -77,7 +77,7 @@ static void shrink_liability(struct ubifs_info *c, int nr_to_write)
> */
> static int run_gc(struct ubifs_info *c)
> {
> - int err, lnum;
> + int lnum;
>
> /* Make some free space by garbage-collecting dirty space */
> down_read(&c->commit_sem);
> @@ -88,10 +88,7 @@ static int run_gc(struct ubifs_info *c)
>
> /* GC freed one LEB, return it to lprops */
> dbg_budg("GC freed LEB %d", lnum);
> - err = ubifs_return_leb(c, lnum);
> - if (err)
> - return err;
> - return 0;
> + return = ubifs_return_leb(c, lnum);
> }
>
Apart from the other issues discussed below and in v1, I don't
believe that this _ever_ compiled successfully.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2] ubifs: compress lines for immediate return Heiko Schocher <hs@denx.de> - 2016-09-05 09:00 +0200
Re: [PATCH v2] ubifs: compress lines for immediate return Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-09-05 14:50 +0200
Re: [PATCH v2] ubifs: compress lines for immediate return Heiko Schocher <hs@denx.de> - 2016-09-05 15:10 +0200
Re: [PATCH v2] ubifs: compress lines for immediate return Richard Weinberger <richard@nod.at> - 2016-09-05 15:40 +0200
Re: [PATCH v2] ubifs: compress lines for immediate return Heiko Schocher <hs@denx.de> - 2016-09-06 06:40 +0200
Re: [PATCH v2] ubifs: compress lines for immediate return David Oberhollenzer <david.oberhollenzer@sigma-star.at> - 2016-09-05 15:20 +0200
Re: [PATCH v2] ubifs: compress lines for immediate return Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-09-05 15:30 +0200
csiph-web