Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1476310

Re: [PATCH] lpfc: mark symbols static where possible

Show all headers | View raw

On Sunday, September 4, 2016 3:07:27 PM CEST Baoyou Xie wrote:
> We get a few warnings when building kernel with W=1:
> drivers/scsi/lpfc/lpfc_sli.c:5693:1: warning: no previous prototype for 'lpfc_set_features' [-Wmissing-prototypes]
> drivers/scsi/lpfc/lpfc_sli.c:8972:1: warning: no previous prototype for 'lpfc_sli_calc_ring' [-Wmissing-prototypes]
> drivers/scsi/lpfc/lpfc_mbox.c:2264:1: warning: no previous prototype for 'lpfc_mbx_cmpl_rdp_link_stat' [-Wmissing-prototypes]
> ....
> 
> In fact, these functions are only used in the file in which they are
> declared and don't need a declaration, but can be made static.
> so this patch marks these functions with 'static'.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> 

Acked-by: Arnd Bergmann <arnd@arndb.de>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] lpfc: mark symbols static where possible Baoyou Xie <baoyou.xie@linaro.org> - 2016-09-04 09:10 +0200
  Re: [PATCH] lpfc: mark symbols static where possible Arnd Bergmann <arnd@arndb.de> - 2016-09-05 13:20 +0200

csiph-web