Re: fix:rtl8xxxu_core: mark symbols static where possible

From	Kalle Valo <kvalo@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: fix:rtl8xxxu_core: mark symbols static where possible
Date	2016-09-03 12:30 +0200
Message-ID	<sdgn0-3VD-9@gated-at.bofh.it> (permalink)
References	<saOuS-6JU-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Baoyou Xie <baoyou.xie@linaro.org> wrote:
> We get 1 warning about global functions without a declaration
> in the rtl8xxxu rtl8xxxu_core.c when building with W=1:
> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:898:1: warning: no previous prototype for 'rtl8xxxu_gen1_h2c_cmd' [-Wmissing-prototypes]
> 
> In fact, this function is only used in the file in which it is declared
> and don't need a declaration, but can be made static.
> so this patch marks it 'static'.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>

The title should be "rtl8xxxu: ". See:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#subject_name

Also I assume Jes will take this.

-- 
Sent by pwcli
https://patchwork.kernel.org/patch/9302457/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] fix:rtl8xxxu_core: mark symbols static where possible Baoyou Xie <baoyou.xie@linaro.org> - 2016-08-27 18:20 +0200
  Re: fix:rtl8xxxu_core: mark symbols static where possible Kalle Valo <kvalo@codeaurora.org> - 2016-09-03 12:30 +0200

csiph-web