Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1475594

Re: [PATCH] s390: Remove deprecated create_singlethread_workqueue

Show all headers | View raw

On Wed, Aug 31, 2016 at 10:31:10AM -0400, Tejun Heo wrote:
> On Wed, Aug 31, 2016 at 01:57:20AM +0530, Bhaktipriya Shridhar wrote:
> > The workqueue "appldata_wq" has been replaced with an ordered dedicated
> > workqueue.
> > 
> > WQ_MEM_RECLAIM has not been set since the workqueue is not being used on
> > a memory reclaim path.
> > 
> > The adapter->work_queue queues multiple work items viz
> > &adapter->scan_work, &port->rport_work, &adapter->ns_up_work,
> > &adapter->stat_work, adapter->work_queue, &adapter->events.work,
> > &port->gid_pn_work, &port->test_link_work. Hence, an ordered
> > dedicated workqueue has been used.
> > 
> > WQ_MEM_RECLAIM has been set to ensure forward progress under memory
> > pressure.
> 
> I have no idea what these drivers do.  s390 folks, can you please shed
> some light on whether these workqueues can be depended on during
> memory reclaim?

The appldata device driver is only needed to gather statistical data and
therefore my wait when memory reclaim is in progress.

The zfcp device drivers is a SCSI-over-FC device driver and hence we depend
on it during memory reclaim. So setting WQ_MEM_RECLAIM is the right thing
to do here.

The patch looks ok, and I applied it.

Thanks!

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] s390: Remove deprecated create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-30 22:30 +0200
  Re: [PATCH] s390: Remove deprecated create_singlethread_workqueue Tejun Heo <tj@kernel.org> - 2016-08-31 16:40 +0200
    Re: [PATCH] s390: Remove deprecated create_singlethread_workqueue Heiko Carstens <heiko.carstens@de.ibm.com> - 2016-09-03 13:00 +0200

csiph-web