Re: [PATCH] virtio-blk: Generate uevent after attribute available

From	Fam Zheng <famz@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] virtio-blk: Generate uevent after attribute available
Date	2016-09-03 09:20 +0200
Message-ID	<sddp8-2bY-3@gated-at.bofh.it> (permalink)
References	<rOR6p-EK-5@gated-at.bofh.it> <rP0t4-730-37@gated-at.bofh.it> <rPcud-65h-3@gated-at.bofh.it> <sd5Bf-5vL-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, 09/03 01:56, Michael S. Tsirkin wrote:
> On Wed, Jun 29, 2016 at 09:24:15AM +0800, Fam Zheng wrote:
> > On Tue, 06/28 04:45, Christoph Hellwig wrote:
> > > On Tue, Jun 28, 2016 at 10:39:15AM +0800, Fam Zheng wrote:
> > > > Userspace listens to the KOBJ_ADD uevent generated in add_disk. At that
> > > > point we haven't created the serial attribute file, therefore depending
> > > > on how fast udev reacts, the /dev/disk/by-id/ entry doesn't always get
> > > > created.
> > > > 
> > > > This race condition can be easily reproduced by hot plugging a number of
> > > > virtio-blk disks.
> > > > 
> > > > Also in systemd, there used to be a related workaround in udev rules
> > > > called 'WAIT_FOR="serial"', but it is removed in later versions.
> > > > 
> > > > Now let's generate a KOBJ_CHANGE event after the attributes are ready.
> > > 
> > > The same race is present in other drivers as well, e.g. nvme.  Please
> > > find a way to make this work properly without needing to hack every
> > > driver to send events manually.
> > 
> > OK, I'll take a look today!
> > 
> > Fam
> 
> Was this fixed in the generic code?

A proposed fix is:

https://lkml.org/lkml/2016/8/17/81

Fam

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] virtio-blk: Generate uevent after attribute available "Michael S. Tsirkin" <mst@redhat.com> - 2016-09-03 01:00 +0200
  Re: [PATCH] virtio-blk: Generate uevent after attribute available Fam Zheng <famz@redhat.com> - 2016-09-03 09:20 +0200

csiph-web