Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1475559

[PATCH] staging/android: mark sync_timeline_create() static

From Baoyou Xie <baoyou.xie@linaro.org>
Newsgroups linux.kernel
Subject [PATCH] staging/android: mark sync_timeline_create() static
Date 2016-09-03 08:40 +0200
Message-ID <sdcMp-1Kd-5@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


We get 1 warning when building kernel with W=1:
drivers/staging/android/sw_sync.c:56:23: warning: no previous prototype for 'sync_timeline_create' [-Wmissing-prototypes]

In fact, this function is only used in the file in which it is
declared and don't need a declaration, but can be made static.
so this patch marks this function with 'static'.

Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
 drivers/staging/android/sw_sync.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/android/sw_sync.c b/drivers/staging/android/sw_sync.c
index 115c917..99a197c 100644
--- a/drivers/staging/android/sw_sync.c
+++ b/drivers/staging/android/sw_sync.c
@@ -53,7 +53,7 @@ static inline struct sync_pt *fence_to_sync_pt(struct fence *fence)
  * Creates a new sync_timeline. Returns the sync_timeline object or NULL in
  * case of error.
  */
-struct sync_timeline *sync_timeline_create(const char *name)
+static struct sync_timeline *sync_timeline_create(const char *name)
 {
 	struct sync_timeline *obj;
 
-- 
2.7.4

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCH] staging/android: mark sync_timeline_create() static Baoyou Xie <baoyou.xie@linaro.org> - 2016-09-03 08:40 +0200
  Re: [PATCH] staging/android: mark sync_timeline_create() static Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-09-04 17:50 +0200

csiph-web