Re: [PATCH] ubifs: compress lines for immediate return

From	Heiko Schocher <hs@denx.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ubifs: compress lines for immediate return
Date	2016-09-05 08:50 +0200
Message-ID	<sdVJv-8v5-3@gated-at.bofh.it> (permalink)
References	<sdUkp-7H5-19@gated-at.bofh.it> <sdVzP-8rK-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello Richard,

Am 05.09.2016 um 08:28 schrieb Richard Weinberger:
> Heiko,
>
> On 05.09.2016 06:59, Heiko Schocher wrote:
>> fix the following code:
>>
>> -ret = expression;
>> -if (ret)
>> -        return ret;
>> -return 0;
>> +return expression;
>
> "Fix"? ;-)
> What was broken?

Ok, fix is to hard spoken ... nothing broken, sorry for confusing!

> I agree that we can write the expression in a different way, but is it really worth it?

I think yes ...

> Is this part of a tree-wide cleanup?

Yes, and I thought it is worth to change this part in linux too.

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ubifs: compress lines for immediate return Heiko Schocher <hs@denx.de> - 2016-09-05 07:10 +0200
  Re: [PATCH] ubifs: compress lines for immediate return Richard Weinberger <richard@nod.at> - 2016-09-05 08:30 +0200
    Re: [PATCH] ubifs: compress lines for immediate return Richard Weinberger <richard@nod.at> - 2016-09-05 08:40 +0200
    Re: [PATCH] ubifs: compress lines for immediate return Heiko Schocher <hs@denx.de> - 2016-09-05 08:50 +0200

csiph-web