Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1476020

[PATCH] x86-ksysfs: Use kmalloc_array() in create_setup_data_nodes()

From SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups linux.kernel
Subject [PATCH] x86-ksysfs: Use kmalloc_array() in create_setup_data_nodes()
Date 2016-09-04 22:30 +0200
Message-ID <sdMdb-2eK-11@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 4 Sep 2016 22:15:09 +0200

A multiplication for the size determination of a memory allocation
indicated that an array data structure should be processed.
Thus use the corresponding function "kmalloc_array".

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 arch/x86/kernel/ksysfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/ksysfs.c b/arch/x86/kernel/ksysfs.c
index 4afc67f..cddf3c6 100644
--- a/arch/x86/kernel/ksysfs.c
+++ b/arch/x86/kernel/ksysfs.c
@@ -283,7 +283,7 @@ static int __init create_setup_data_nodes(struct kobject *parent)
 	if (ret)
 		goto out_setup_data_kobj;
 
-	kobjp = kmalloc(sizeof(*kobjp) * nr, GFP_KERNEL);
+	kobjp = kmalloc_array(nr, sizeof(*kobjp), GFP_KERNEL);
 	if (!kobjp) {
 		ret = -ENOMEM;
 		goto out_setup_data_kobj;
-- 
2.9.3

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCH] x86-ksysfs: Use kmalloc_array() in create_setup_data_nodes() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-04 22:30 +0200
  Re: [PATCH] x86-ksysfs: Use kmalloc_array() in create_setup_data_nodes() Kees Cook <keescook@chromium.org> - 2016-09-07 00:00 +0200
    Re: x86-ksysfs: Use kmalloc_array() in create_setup_data_nodes() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-07 10:00 +0200
      Re: x86-ksysfs: Use kmalloc_array() in create_setup_data_nodes() Paolo Bonzini <pbonzini@redhat.com> - 2016-09-07 12:40 +0200
        Re: x86-ksysfs: Use kmalloc_array() in create_setup_data_nodes() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-07 13:30 +0200
          Re: x86-ksysfs: Use kmalloc_array() in create_setup_data_nodes() Paolo Bonzini <pbonzini@redhat.com> - 2016-09-07 13:30 +0200
            Re: x86-ksysfs: Use kmalloc_array() in create_setup_data_nodes() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-07 13:50 +0200
              Re: x86-ksysfs: Use kmalloc_array() in create_setup_data_nodes() Kees Cook <keescook@chromium.org> - 2016-09-07 18:30 +0200
                Re: x86-ksysfs: Use kmalloc_array() in create_setup_data_nodes() Joe Perches <joe@perches.com> - 2016-09-07 18:40 +0200
                Re: x86-ksysfs: Use kmalloc_array() in create_setup_data_nodes() Kees Cook <keescook@chromium.org> - 2016-09-07 19:10 +0200
                Re: x86-ksysfs: Use kmalloc_array() in create_setup_data_nodes() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-07 19:00 +0200

csiph-web