Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1476006

[PATCH 3/5] drivers: staging: rtl8723au: core: Refactor pointless branching

From Matthias Beyer <mail@beyermatthias.de>
Newsgroups linux.kernel
Subject [PATCH 3/5] drivers: staging: rtl8723au: core: Refactor pointless branching
Date 2016-09-04 21:30 +0200
Message-ID <sdLh8-1yo-9@gated-at.bofh.it> (permalink)
References <sdLh8-1yo-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


As ether_addr_equal returns a bool, we can simply use the return value
to set the variable.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Manuel Messner <manuel.johannes.messner@hs-furtwangen.de>
---
 drivers/staging/rtl8723au/core/rtw_mlme.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/rtl8723au/core/rtw_mlme.c b/drivers/staging/rtl8723au/core/rtw_mlme.c
index da9f298..196447b 100644
--- a/drivers/staging/rtl8723au/core/rtw_mlme.c
+++ b/drivers/staging/rtl8723au/core/rtw_mlme.c
@@ -1062,11 +1062,8 @@ void rtw_joinbss_event_prehandle23a(struct rtw_adapter *adapter, u8 *pbuf)
 			 pmlmepriv->assoc_ssid.ssid);
 	}
 
-	if (ether_addr_equal(pnetwork->network.MacAddress,
-			     cur_network->network.MacAddress))
-		the_same_macaddr = true;
-	else
-		the_same_macaddr = false;
+	the_same_macaddr = ether_addr_equal(pnetwork->network.MacAddress,
+					    cur_network->network.MacAddress);
 
 	pnetwork->network.Length = get_wlan_bssid_ex_sz(&pnetwork->network);
 	if (pnetwork->network.Length > sizeof(struct wlan_bssid_ex)) {
-- 
2.9.3

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/5] Some cleanup patches for drivers/staging/rtl8723au/core/rtw_mlme.c Matthias Beyer <mail@beyermatthias.de> - 2016-09-04 21:30 +0200
  [PATCH 3/5] drivers: staging: rtl8723au: core: Refactor pointless branching Matthias Beyer <mail@beyermatthias.de> - 2016-09-04 21:30 +0200
  [PATCH 4/5] drivers: staging: rtl8723au: core: Fix "space prohibited" warning Matthias Beyer <mail@beyermatthias.de> - 2016-09-04 21:30 +0200
  [PATCH 2/5] drivers: staging: rtl8723au: core: simplify if-break-else Matthias Beyer <mail@beyermatthias.de> - 2016-09-04 21:30 +0200
  [PATCH 5/5] drivers: staging: rtl8723au: core: Fix indentation Matthias Beyer <mail@beyermatthias.de> - 2016-09-04 21:40 +0200
  Re: [PATCH 0/5] Some cleanup patches for drivers/staging/rtl8723au/core/rtw_mlme.c Jes Sorensen <Jes.Sorensen@redhat.com> - 2016-09-06 18:10 +0200
    Re: [PATCH 0/5] Some cleanup patches for  drivers/staging/rtl8723au/core/rtw_mlme.c Joe Perches <joe@perches.com> - 2016-09-06 18:10 +0200
      Re: [PATCH 0/5] Some cleanup patches for drivers/staging/rtl8723au/core/rtw_mlme.c Jes Sorensen <Jes.Sorensen@redhat.com> - 2016-09-06 18:20 +0200
    Re: [PATCH 0/5] Some cleanup patches for  drivers/staging/rtl8723au/core/rtw_mlme.c Matthias Beyer <mail@beyermatthias.de> - 2016-09-07 09:50 +0200

csiph-web