Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1476003

Re: [PATCH] x86/amd_nb: Use kmalloc_array() in amd_cache_gart()

Show all headers | View raw

On Sun, 2016-09-04 at 21:08 +0200, SF Markus Elfring wrote:

> * A multiplication for the size determination of a memory allocation
>   indicated that an array data structure should be processed.
>   Thus use the corresponding function "kmalloc_array".
> 
>   This issue was detected by using the Coccinelle software.
> 
> * Replace the specification of a data type by a pointer dereference
>   to make the corresponding size determination a bit safer according to
>   the Linux coding style convention.
[]
> diff --git a/arch/x86/kernel/amd_nb.c b/arch/x86/kernel/amd_nb.c
[]
> @@ -226,7 +226,9 @@ static void amd_cache_gart(void)
>  	if (!amd_nb_has_feature(AMD_NB_GART))
>  		return;
>  
> -	flush_words = kmalloc(amd_nb_num() * sizeof(u32), GFP_KERNEL);
> +	flush_words = kmalloc_array(amd_nb_num(),
> +				    sizeof(*flush_words),
> +				    GFP_KERNEL);

Markus, this sort of change really isn't very useful.

amd_nb_num is a u16 and is really just a count of
northbridges in the system.

It'll never be a particular high number that could
possibly overflow a size_t of num * sizeof(u32).

Detecting an inconsistency is different than an issue
that has any real significance.

Please stop blindly converting these from one form to
another.  Please inspect these potential changes
first and find instances where this conversion could
actually matter before sending auto-generated patches.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] x86/amd_nb: Use kmalloc_array() in amd_cache_gart() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-04 21:20 +0200
  Re: [PATCH] x86/amd_nb: Use kmalloc_array() in amd_cache_gart() Joe Perches <joe@perches.com> - 2016-09-04 21:30 +0200

csiph-web