Re: [PATCH 2/2] Staging: comedi: ni_670x.c: Fix warnings and check.

From	Amit Ghadge <amitg.b14@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] Staging: comedi: ni_670x.c: Fix warnings and check.
Date	2016-09-04 12:20 +0200
Message-ID	<sdCGS-5AL-13@gated-at.bofh.it> (permalink)
References	<sdpzY-1pL-11@gated-at.bofh.it> <sdpzY-1pL-9@gated-at.bofh.it> <sdB85-6mo-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

I will be send individual patches.

I was try,
 make M=drivers/staging/comedi/

No issue generated, Is there have any other option to test these changes?


Amit G

On Sun, Sep 4, 2016 at 2:05 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Sun, Sep 04, 2016 at 01:41:03AM +0530, Amit Ghadge wrote:
>> Fixes checkpatch warning:
>> WARNING: Block comments use * on subsequent lines
>>
>> Replace (1<<7) by BIT(7) in the file ni_670x.c to get rid
>> of checkpatch.pl "CHECK" output "Prefer using the BIT macro".
>> Replace Avoid CamelCase range_0_20mA to range_0_20ma.
>
> That's multiple things in the same patch, and you didn't even test build
> your change :(
>
> Please do better than this in the future.
>
> greg k-h

Thread

[PATCH 2/2] Staging: comedi: ni_670x.c: Fix warnings and check. Amit Ghadge <amitg.b14@gmail.com> - 2016-09-03 22:20 +0200
  Re: [PATCH 2/2] Staging: comedi: ni_670x.c: Fix warnings and check. Greg KH <gregkh@linuxfoundation.org> - 2016-09-04 10:40 +0200
    Re: [PATCH 2/2] Staging: comedi: ni_670x.c: Fix warnings and check. Amit Ghadge <amitg.b14@gmail.com> - 2016-09-04 12:20 +0200
      Re: [PATCH 2/2] Staging: comedi: ni_670x.c: Fix warnings and check. Ian Abbott <abbotti@mev.co.uk> - 2016-09-05 15:30 +0200
  Re: [PATCH 2/2] Staging: comedi: ni_670x.c: Fix warnings and check. Ian Abbott <abbotti@mev.co.uk> - 2016-09-05 15:40 +0200
    Re: [PATCH 2/2] Staging: comedi: ni_670x.c: Fix warnings and check. Amit Ghadge <amitg.b14@gmail.com> - 2016-09-05 16:20 +0200

csiph-web