Re: [RFC 1/3] x86/vdso: create vdso file, use it for mapping

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Al Viro <viro@ZenIV.linux.org.uk>
Newsgroups	linux.kernel
Subject	Re: [RFC 1/3] x86/vdso: create vdso file, use it for mapping
Date	Sat, 03 Sep 2016 02:20:02 +0200
Message-ID	<sd6QG-6ph-19@gated-at.bofh.it> (permalink)
References	<sa8YG-5nC-19@gated-at.bofh.it> <sa8YG-5nC-21@gated-at.bofh.it> <sbSmJ-67O-3@gated-at.bofh.it>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.6.1 (2016-04-27)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	8
Organization	linux.* mail to news gateway
X-Original-Cc	Dmitry Safonov <dsafonov@virtuozzo.com>, linux-kernel@vger.kernel.org, mingo@redhat.com, luto@amacapital.net, tglx@linutronix.de, hpa@zytor.com, x86@kernel.org, 0x7f454c46@gmail.com, rostedt@goodmis.org
X-Original-Date	Sat, 3 Sep 2016 01:13:01 +0100
X-Original-Message-ID	<20160903001301.GZ2356@ZenIV.linux.org.uk>
X-Original-References	<20160825152110.25663-1-dsafonov@virtuozzo.com> <20160825152110.25663-2-dsafonov@virtuozzo.com> <20160830143311.GA23007@redhat.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1475508

Show key headers only | View raw

On Tue, Aug 30, 2016 at 04:33:12PM +0200, Oleg Nesterov wrote:
> > +	inode = ramfs_get_inode(sb, NULL, S_IFREG | S_IRUGO | S_IXUGO, 0);

> Not sure... I think alloc_anon_inode() makes more sense.

	Compared to this, you mean?  It's going to give you the wrong
permissions/i_op/a_ops, and you'll have to assign them manually.  ramfs
already gives the right ones for what's wanted, AFAICS.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RFC 1/3] x86/vdso: create vdso file, use it for mapping Oleg Nesterov <oleg@redhat.com> - 2016-08-30 16:40 +0200
  Re: [RFC 1/3] x86/vdso: create vdso file, use it for mapping Dmitry Safonov <0x7f454c46@gmail.com> - 2016-08-30 17:00 +0200
  Re: [RFC 1/3] x86/vdso: create vdso file, use it for mapping Al Viro <viro@ZenIV.linux.org.uk> - 2016-09-03 02:20 +0200

csiph-web