Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1475491

Re: screen rotation flipped in 4.8-rc

Show all headers | View raw

On Tue, 2016-08-30 at 22:42 +0000, Pandruvada, Srinivas wrote:
> Hi All,
> 
> I observed that using iio-sensor-proxy.service, the auto screen
> rotation flipped on my laptop (Normal -> vertical, vertical->normal)
> using kernel v4.8.
> 
> Anyone else has seen this?
> 
> I did a bisect and found a commit, which I am not sure how can it
> impact.
> 
> 
> commit 703b5faf22fbddf984a361e6555f3a03fdba63d9
> Author: George Spelvin <linux@sciencehorizons.net>
> Date:   Fri Jun 10 00:22:12 2016 -0400
> 
[...]

It turns out to be some assumption user space program is making about
the traversing directory using glib call g_dir_read_name(). 

With the commit 703b5faf22fbddf984a361e6555f3a03fdba63d9 (fs/dcache.c:
Save one 32-bit multiply in dcache lookup)
 in kernel 4.8-rc, somehow the order is changed (so the in_accel_y was
appearing before in_accel_x )

I modified user space program to use correct iio scan element index to
determine byte offset instead depending on the glib_dir_read_name,
which doesn't guarantee any order.

I sent a pull request to author of iio-sensor-proxy to review.

Hadess,
	Please look.

https://github.com/hadess/iio-sensor-proxy/pull/99/commits/de80c50b2678
2ba6e899ee5a95b31b28790c940d


Thanks,
Srinivas

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

screen rotation flipped in 4.8-rc "Pandruvada, Srinivas" <srinivas.pandruvada@intel.com> - 2016-08-31 00:50 +0200
  Re: screen rotation flipped in 4.8-rc Matt Ranostay <mranostay@gmail.com> - 2016-08-31 02:50 +0200
    Re: screen rotation flipped in 4.8-rc Matt Ranostay <mranostay@gmail.com> - 2016-08-31 22:30 +0200
      Re: screen rotation flipped in 4.8-rc "Pandruvada, Srinivas" <srinivas.pandruvada@intel.com> - 2016-08-31 22:40 +0200
        Re: screen rotation flipped in 4.8-rc Matt Ranostay <mranostay@gmail.com> - 2016-08-31 22:50 +0200
          Re: screen rotation flipped in 4.8-rc Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> - 2016-09-01 01:00 +0200
            Re: screen rotation flipped in 4.8-rc Matt Ranostay <mranostay@gmail.com> - 2016-09-01 02:50 +0200
  Re: screen rotation flipped in 4.8-rc Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> - 2016-09-03 00:50 +0200
    Re: screen rotation flipped in 4.8-rc Jonathan Cameron <jic23@kernel.org> - 2016-09-03 17:10 +0200
    Re: screen rotation flipped in 4.8-rc Bastien Nocera <hadess@hadess.net> - 2016-09-06 14:30 +0200

csiph-web