Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1475425
| From | Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 2/4] tpm_crb: remove wmb()'s |
| Date | 2016-09-02 21:40 +0200 |
| Message-ID | <sd2tI-3Bl-33@gated-at.bofh.it> (permalink) |
| References | <sd2tH-3Bl-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
wmb()'s are not needed as iowrite32() is used. Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> --- drivers/char/tpm/tpm_crb.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/char/tpm/tpm_crb.c b/drivers/char/tpm/tpm_crb.c index 1801f38..358c475 100644 --- a/drivers/char/tpm/tpm_crb.c +++ b/drivers/char/tpm/tpm_crb.c @@ -175,9 +175,6 @@ static void crb_cancel(struct tpm_chip *chip) iowrite32(cpu_to_le32(CRB_CANCEL_INVOKE), &priv->cca->cancel); - /* Make sure that cmd is populated before issuing cancel. */ - wmb(); - if ((priv->flags & CRB_FL_ACPI_START) && crb_do_acpi_start(chip)) dev_err(&chip->dev, "ACPI Start failed\n"); } -- 2.7.4
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/4] Small fixes and cleanups for tpm_crb Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-09-02 21:40 +0200
[PATCH 1/4] tpm_crb: fix crb_req_canceled behavior Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-09-02 21:40 +0200
[PATCH 4/4] tpm_crb: fix incorrect values of cmdReady and goIdle bits Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-09-02 21:40 +0200
Re: [PATCH 4/4] tpm_crb: fix incorrect values of cmdReady and goIdle bits Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-09-02 21:50 +0200
[PATCH 3/4] tpm_crb: refine the naming of constants Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-09-02 21:40 +0200
[PATCH 2/4] tpm_crb: remove wmb()'s Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-09-02 21:40 +0200
Re: [PATCH 0/4] Small fixes and cleanups for tpm_crb Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-09-03 08:40 +0200
Re: [PATCH 0/4] Small fixes and cleanups for tpm_crb Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-09-03 08:50 +0200
Re: [PATCH 0/4] Small fixes and cleanups for tpm_crb Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-09-08 12:30 +0200
Re: [PATCH 0/4] Small fixes and cleanups for tpm_crb Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-09-08 13:40 +0200
csiph-web