Re: [PATCHv2 2/4] staging: android: ion: Pull out ion ioctls to a separate file

From	Laura Abbott <labbott@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCHv2 2/4] staging: android: ion: Pull out ion ioctls to a separate file
Date	2016-09-02 22:00 +0200
Message-ID	<sd2N3-3HS-9@gated-at.bofh.it> (permalink)
References	<scIY1-7U6-1@gated-at.bofh.it> <scIY1-7U6-7@gated-at.bofh.it> <scW4W-7YZ-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 09/02/2016 05:44 AM, Greg Kroah-Hartman wrote:
> On Thu, Sep 01, 2016 at 03:40:42PM -0700, Laura Abbott wrote:
>>
>> The number of Ion ioctls may continue to grow along with necessary
>> validation. Pull it out into a separate file for easier management
>> and review.
>>
>> Signed-off-by: Laura Abbott <labbott@redhat.com>
>> ---
>>  drivers/staging/android/ion/Makefile    |   3 +-
>>  drivers/staging/android/ion/ion-ioctl.c | 144 ++++++++++++++++++++++
>>  drivers/staging/android/ion/ion.c       | 210 ++------------------------------
>>  drivers/staging/android/ion/ion_priv.h  |  91 ++++++++++++++
>>  4 files changed, 244 insertions(+), 204 deletions(-)
>>  create mode 100644 drivers/staging/android/ion/ion-ioctl.c
>
> This patch doesn't apply cleanly to my tree, are we out of sync somehow?
>
> Can you rebase your outstanding patches against my staging-testing
> branch and resend?
>
> thanks,
>
> greg k-h
>

Looks like I missed a rebase with one of the cleanup patches. I'll resend.

Thanks,
Laura

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCHv2 0/4] New Ion ioctls Laura Abbott <labbott@redhat.com> - 2016-09-02 00:50 +0200
  [PATCHv2 4/4] staging: android: ion: Add ioctl to query available heaps Laura Abbott <labbott@redhat.com> - 2016-09-02 00:50 +0200
    Re: [PATCHv2 4/4] staging: android: ion: Add ioctl to query  available heaps Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-02 08:20 +0200
      Re: [PATCHv2 4/4] staging: android: ion: Add ioctl to query available  heaps Laura Abbott <labbott@redhat.com> - 2016-09-02 22:50 +0200
        Re: [PATCHv2 4/4] staging: android: ion: Add ioctl to query  available heaps Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-03 15:00 +0200
  [PATCHv2 1/4] staging: android: ion: Drop heap type masks Laura Abbott <labbott@redhat.com> - 2016-09-02 00:50 +0200
    Re: [PATCHv2 1/4] staging: android: ion: Drop heap type masks Brian Starkey <brian.starkey@arm.com> - 2016-09-02 15:50 +0200
      Re: [PATCHv2 1/4] staging: android: ion: Drop heap type masks Laura Abbott <labbott@redhat.com> - 2016-09-02 21:40 +0200
        Re: [PATCHv2 1/4] staging: android: ion: Drop heap type masks Brian Starkey <brian.starkey@arm.com> - 2016-09-05 13:30 +0200
          Re: [PATCHv2 1/4] staging: android: ion: Drop heap type masks Laura Abbott <labbott@redhat.com> - 2016-09-07 00:20 +0200
            Re: [PATCHv2 1/4] staging: android: ion: Drop heap type masks Brian Starkey <brian.starkey@arm.com> - 2016-09-07 11:00 +0200
  [PATCHv2 3/4] staging: android: ion: Add an ioctl for ABI checking Laura Abbott <labbott@redhat.com> - 2016-09-02 00:50 +0200
    Re: [PATCHv2 3/4] staging: android: ion: Add an ioctl for ABI  checking Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-02 08:20 +0200
      Re: [PATCHv2 3/4] staging: android: ion: Add an ioctl for ABI  checking Laura Abbott <labbott@redhat.com> - 2016-09-02 22:30 +0200
    Re: [Linaro-mm-sig] [PATCHv2 3/4] staging: android: ion: Add an ioctl for ABI checking Arnd Bergmann <arnd@arndb.de> - 2016-09-02 11:10 +0200
      Re: [Linaro-mm-sig] [PATCHv2 3/4] staging: android: ion: Add an ioctl  for ABI checking Laura Abbott <labbott@redhat.com> - 2016-09-02 22:40 +0200
        Re: [Linaro-mm-sig] [PATCHv2 3/4] staging: android: ion: Add an ioctl for ABI checking Arnd Bergmann <arnd@arndb.de> - 2016-09-02 23:40 +0200
          Re: [Linaro-mm-sig] [PATCHv2 3/4] staging: android: ion: Add an ioctl  for ABI checking Laura Abbott <labbott@redhat.com> - 2016-09-03 00:20 +0200
  [PATCHv2 2/4] staging: android: ion: Pull out ion ioctls to a separate file Laura Abbott <labbott@redhat.com> - 2016-09-02 00:50 +0200
    Re: [PATCHv2 2/4] staging: android: ion: Pull out ion ioctls to a  separate file Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-02 14:50 +0200
      Re: [PATCHv2 2/4] staging: android: ion: Pull out ion ioctls to a  separate file Laura Abbott <labbott@redhat.com> - 2016-09-02 22:00 +0200

csiph-web