Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1474228

[PATCH] s390/hypfs: Use kmalloc_array() in diag0c_store()

Show all headers | View raw

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 1 Sep 2016 11:30:58 +0200

A multiplication for the size determination of a memory allocation
indicated that an array data structure should be processed.
Thus use the corresponding function "kmalloc_array".

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 arch/s390/hypfs/hypfs_diag0c.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/s390/hypfs/hypfs_diag0c.c b/arch/s390/hypfs/hypfs_diag0c.c
index 0f1927c..61418a8 100644
--- a/arch/s390/hypfs/hypfs_diag0c.c
+++ b/arch/s390/hypfs/hypfs_diag0c.c
@@ -48,7 +48,9 @@ static void *diag0c_store(unsigned int *count)
 
 	get_online_cpus();
 	cpu_count = num_online_cpus();
-	cpu_vec = kmalloc(sizeof(*cpu_vec) * num_possible_cpus(), GFP_KERNEL);
+	cpu_vec = kmalloc_array(num_possible_cpus(),
+				sizeof(*cpu_vec),
+				GFP_KERNEL);
 	if (!cpu_vec)
 		goto fail_put_online_cpus;
 	/* Note: Diag 0c needs 8 byte alignment and real storage */
-- 
2.9.3

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] s390/hypfs: Use kmalloc_array() in diag0c_store() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-01 11:40 +0200
  Re: [PATCH] s390/hypfs: Use kmalloc_array() in diag0c_store() Heiko Carstens <heiko.carstens@de.ibm.com> - 2016-09-01 12:40 +0200
    Re: [PATCH] s390/hypfs: Use kmalloc_array() in diag0c_store() Paolo Bonzini <pbonzini@redhat.com> - 2016-09-01 17:40 +0200
      Re: [PATCH] s390/hypfs: Use kmalloc_array() in diag0c_store() Michael Holzheu <holzheu@linux.vnet.ibm.com> - 2016-09-01 23:40 +0200

csiph-web