[PATCH v8 03/16] of/numa: add nid check for memory block

From	Zhen Lei <thunder.leizhen@huawei.com>
Newsgroups	linux.kernel
Subject	[PATCH v8 03/16] of/numa: add nid check for memory block
Date	2016-09-01 09:00 +0200
Message-ID	<scu8F-5sK-17@gated-at.bofh.it> (permalink)
References	<scu8F-5sK-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

If the numa-id which was configured in memory@ devicetree node is greater
than MAX_NUMNODES, we should report a warning. We have done this for cpus
and distance-map dt nodes, this patch help them to be consistent.

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
 drivers/of/of_numa.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/of/of_numa.c b/drivers/of/of_numa.c
index 7b3fbdc..c1bd62c 100644
--- a/drivers/of/of_numa.c
+++ b/drivers/of/of_numa.c
@@ -75,6 +75,11 @@ static int __init of_numa_parse_memory_nodes(void)
 			 */
 			continue;

+		if (nid >= MAX_NUMNODES) {
+			pr_warn("NUMA: Node id %u exceeds maximum value\n", nid);
+			r = -EINVAL;
+		}
+
 		for (i = 0; !r && !of_address_to_resource(np, i, &rsrc); i++)
 			r = numa_add_memblk(nid, rsrc.start, rsrc.end + 1);

--
2.5.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v8 03/16] of/numa: add nid check for memory block Zhen Lei <thunder.leizhen@huawei.com> - 2016-09-01 09:00 +0200
  Re: [PATCH v8 03/16] of/numa: add nid check for memory block Rob Herring <robh+dt@kernel.org> - 2016-09-08 15:50 +0200

csiph-web