Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1473942

[PATCH 1/5] net: mediatek: constify ethtool_ops structures

Show all headers | View raw

Check for ethtool_ops structures that are only stored in the ethtool_ops
field of a net_device structure or passed as the second argument to
netdev_set_default_ethtool_ops.  These contexts are declared const, so
ethtool_ops structures that have these properties can be declared as const
also.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r disable optional_qualifier@
identifier i;
position p;
@@
static struct ethtool_ops i@p = { ... };

@ok1@
identifier r.i;
struct net_device e;
position p;
@@
e.ethtool_ops = &i@p;

@ok2@
identifier r.i;
expression e;
position p;
@@
netdev_set_default_ethtool_ops(e, &i@p)

@bad@
position p != {r.p,ok1.p,ok2.p};
identifier r.i;
@@
i@p

@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
 struct ethtool_ops i = { ... };
// </smpl>

Suggested-by: Stephen Hemminger <stephen@networkplumber.org>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

---
 drivers/net/ethernet/mediatek/mtk_eth_soc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
index 1801fd8..98f22cd 100644
--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
+++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
@@ -1692,7 +1692,7 @@ static void mtk_get_ethtool_stats(struct net_device *dev,
 	} while (u64_stats_fetch_retry_irq(&hwstats->syncp, start));
 }
 
-static struct ethtool_ops mtk_ethtool_ops = {
+static const struct ethtool_ops mtk_ethtool_ops = {
 	.get_settings		= mtk_get_settings,
 	.set_settings		= mtk_set_settings,
 	.get_drvinfo		= mtk_get_drvinfo,

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] constify ethtool_ops structures Julia Lawall <Julia.Lawall@lip6.fr> - 2016-09-01 00:40 +0200
  [PATCH 4/5] r8152: constify ethtool_ops structures Julia Lawall <Julia.Lawall@lip6.fr> - 2016-09-01 00:50 +0200
    Re: [PATCH 4/5] r8152: constify ethtool_ops structures David Miller <davem@davemloft.net> - 2016-09-01 05:50 +0200
  [PATCH 1/5] net: mediatek: constify ethtool_ops structures Julia Lawall <Julia.Lawall@lip6.fr> - 2016-09-01 00:50 +0200
    Re: [PATCH 1/5] net: mediatek: constify ethtool_ops structures David Miller <davem@davemloft.net> - 2016-09-01 05:50 +0200
  [PATCH 5/5] net: axienet: constify ethtool_ops structures Julia Lawall <Julia.Lawall@lip6.fr> - 2016-09-01 00:50 +0200
    Re: [PATCH 5/5] net: axienet: constify ethtool_ops structures David Miller <davem@davemloft.net> - 2016-09-01 05:50 +0200
  [PATCH 2/5] staging: netlogic: constify ethtool_ops structures Julia Lawall <Julia.Lawall@lip6.fr> - 2016-09-01 00:50 +0200

csiph-web