Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1473898

Re: [PATCH -v2] mm: Don't use radix tree writeback tags for pages in swap cache

From Andi Kleen <andi@firstfloor.org>
Newsgroups linux.kernel
Subject Re: [PATCH -v2] mm: Don't use radix tree writeback tags for pages in swap cache
Date 2016-08-31 23:40 +0200
Message-ID <scloK-7GT-25@gated-at.bofh.it> (permalink)
References <sbV1g-7PN-7@gated-at.bofh.it> <sc9QB-xQ-11@gated-at.bofh.it> <scft0-44i-21@gated-at.bofh.it> <scfMl-4aI-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Mel Gorman <mgorman@techsingularity.net> writes:
>
> __GFP_BITS_SHIFT + 5 (AS_NO_WRITEBACK_TAGS) = 31
>
> mapping->flags is a combination of AS and GFP flags so increasing
> __GFP_BITS_SHIFT overflows mapping->flags on 32-bit as gfp_t is an
> unsigned int.

Couldn't we just split mapping->flags into two fields?
I'm sure more GFP bits will be needed eventually.

-Andi

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH -v2] mm: Don't use radix tree writeback tags for pages in swap cache "Huang, Ying" <ying.huang@intel.com> - 2016-08-30 19:30 +0200
  Re: [PATCH -v2] mm: Don't use radix tree writeback tags for pages  in swap cache Rik van Riel <riel@redhat.com> - 2016-08-30 20:40 +0200
  Re: [PATCH -v2] mm: Don't use radix tree writeback tags for pages in  swap cache Mel Gorman <mgorman@techsingularity.net> - 2016-08-31 11:20 +0200
    Re: [PATCH -v2] mm: Don't use radix tree writeback tags for pages in swap cache "Huang\, Ying" <ying.huang@intel.com> - 2016-08-31 17:20 +0200
      Re: [PATCH -v2] mm: Don't use radix tree writeback tags for pages in  swap cache Mel Gorman <mgorman@techsingularity.net> - 2016-08-31 17:40 +0200
        Re: [PATCH -v2] mm: Don't use radix tree writeback tags for pages in swap cache "Huang\, Ying" <ying.huang@intel.com> - 2016-08-31 17:50 +0200
        Re: [PATCH -v2] mm: Don't use radix tree writeback tags for pages in swap cache Andi Kleen <andi@firstfloor.org> - 2016-08-31 23:40 +0200
    Re: [PATCH -v2] mm: Don't use radix tree writeback tags for pages  in swap cache Andrew Morton <akpm@linux-foundation.org> - 2016-08-31 23:40 +0200
      Re: [PATCH -v2] mm: Don't use radix tree writeback tags for pages in  swap cache Mel Gorman <mgorman@techsingularity.net> - 2016-09-01 11:00 +0200
      Re: [PATCH -v2] mm: Don't use radix tree writeback tags for pages in  swap cache Michal Hocko <mhocko@kernel.org> - 2016-09-01 11:20 +0200

csiph-web