Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1473922

[PATCH 2/6] clocksource: Defer override invalidation unless clock is unstable

Show all headers | View raw

From: Kyle Walker <kwalker@redhat.com>

Clocksources don't get the VALID_FOR_HRES flag until they have been
checked by a watchdog. However, when using an override, the
clocksource_select logic will clear the override value if the
clocksource is not marked VALID_FOR_HRES during that inititial check.
When using the boot arguments clocksource=<foo>, this selection can
run before the watchdog, and can cause the override to be incorrectly
cleared.

To address this condition, the override_name is only invalidated for
unstable clocksources. Otherwise, the override is left intact until after
the watchdog has validated the clocksource as stable/unstable.

Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Richard Cochran <richardcochran@gmail.com>
Cc: Prarit Bhargava <prarit@redhat.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Signed-off-by: Kyle Walker <kwalker@redhat.com>
Signed-off-by: John Stultz <john.stultz@linaro.org>
---
 kernel/time/clocksource.c | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c
index 6a5a310..7e4fad7 100644
--- a/kernel/time/clocksource.c
+++ b/kernel/time/clocksource.c
@@ -600,9 +600,18 @@ static void __clocksource_select(bool skipcur)
 		 */
 		if (!(cs->flags & CLOCK_SOURCE_VALID_FOR_HRES) && oneshot) {
 			/* Override clocksource cannot be used. */
-			pr_warn("Override clocksource %s is not HRT compatible - cannot switch while in HRT/NOHZ mode\n",
-				cs->name);
-			override_name[0] = 0;
+			if (cs->flags & CLOCK_SOURCE_UNSTABLE) {
+				pr_warn("Override clocksource %s is unstable and not HRT compatible - cannot switch while in HRT/NOHZ mode\n",
+					cs->name);
+				override_name[0] = 0;
+			} else {
+				/*
+				 * The override cannot be currently verified.
+				 * Deferring to let the watchdog check.
+				 */
+				pr_info("Override clocksource %s is not currently HRT compatible - deferring\n",
+					cs->name);
+			}
 		} else
 			/* Override clocksource can be used. */
 			best = cs;
-- 
1.9.1

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[GIT PULL][PATCH 0/6] 4.9 timekeeping changes for tip/timers/core John Stultz <john.stultz@linaro.org> - 2016-09-01 00:00 +0200
  [PATCH 4/6] time: Avoid undefined behaviour in timespec64_add_safe() John Stultz <john.stultz@linaro.org> - 2016-09-01 00:00 +0200
    Re: [PATCH 4/6] time: Avoid undefined behaviour in  timespec64_add_safe() Richard Cochran <richardcochran@gmail.com> - 2016-09-01 10:10 +0200
      Re: [PATCH 4/6] time: Avoid undefined behaviour in  timespec64_add_safe() Vegard Nossum <vegard.nossum@oracle.com> - 2016-09-01 11:40 +0200
  [PATCH 6/6] time: alarmtimer: Add tracepoints for alarmtimers John Stultz <john.stultz@linaro.org> - 2016-09-01 00:00 +0200
  [PATCH 2/6] clocksource: Defer override invalidation unless clock is unstable John Stultz <john.stultz@linaro.org> - 2016-09-01 00:00 +0200

csiph-web