Re: [alsa-devel] [PATCH] ASoC: tlv320dac33: Remove deprecated create_singlethread_workqueue

From	Tejun Heo <tj@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [alsa-devel] [PATCH] ASoC: tlv320dac33: Remove deprecated create_singlethread_workqueue
Date	2016-08-31 23:20 +0200
Message-ID	<scl5o-7Av-13@gated-at.bofh.it> (permalink)
References	<sbVXj-8sN-7@gated-at.bofh.it> <scclr-1X7-11@gated-at.bofh.it> <sceZY-3Ew-35@gated-at.bofh.it> <scjdf-6oB-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello, Peter.

On Wed, Aug 31, 2016 at 10:10:47PM +0300, Peter Ujfalusi wrote:
> > What kind of time frame are we talking about?  If it really needs high
> > priority, the right thing to do would be using a WQ_HIGHPRI workqueue.
> 
> In order to be tune the performance and power saving during audio playback
> lower is better, but consistency matters more to be able have stable system.
> I have some latency compensation in the code so it could tolerate some drift,
> but big spikes can cause the codec to go underflow and we can not recover from
> that w/o hard reset of the codec.

Gees, that's a brutal failure mode.

> I do believe that Linux got much better over the years since I wrote the dac33
> driver, so I'm fine with the move to system_wq. The most problematic mode (I
> think it was MODE7LP or smthing) is not upstream so this change should not
> break audio on the n9/n950.

Thanks for the explanation!

-- 
tejun

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ASoC: tlv320dac33: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-30 20:30 +0200
  Re: [alsa-devel] [PATCH] ASoC: tlv320dac33: Remove deprecated  create_singlethread_workqueue Peter Ujfalusi <peter.ujfalusi@ti.com> - 2016-08-31 14:00 +0200
    Re: [alsa-devel] [PATCH] ASoC: tlv320dac33: Remove deprecated  create_singlethread_workqueue Tejun Heo <tj@kernel.org> - 2016-08-31 16:50 +0200
      Re: [alsa-devel] [PATCH] ASoC: tlv320dac33: Remove deprecated  create_singlethread_workqueue Peter Ujfalusi <peter.ujfalusi@ti.com> - 2016-08-31 21:20 +0200
        Re: [alsa-devel] [PATCH] ASoC: tlv320dac33: Remove deprecated  create_singlethread_workqueue Tejun Heo <tj@kernel.org> - 2016-08-31 23:20 +0200

csiph-web