Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1473823
| From | Danny Milosavljevic <dannym@scratchpost.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [linux-sunxi] Re: [PATCH v9 1/2] ASoC: sun4i-codec: Distinguish sun4i from sun7i |
| Date | 2016-08-31 22:20 +0200 |
| Message-ID | <sck9j-718-5@gated-at.bofh.it> (permalink) |
| References | <sbK5P-Fr-3@gated-at.bofh.it> <sbK5Q-Fr-7@gated-at.bofh.it> <schOa-5mI-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi Maxime, On Wed, 31 Aug 2016 19:46:23 +0200 Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > > -#define SUN4I_CODEC_AC_SYS_VERI (0x38) > > -#define SUN4I_CODEC_AC_MIC_PHONE_CAL (0x3c) > > + > > +#define SUN7I_CODEC_AC_DAC_CAL (0x38) > > +#define SUN7I_CODEC_AC_MIC_PHONE_CAL (0x3c) > > That will need at least some mention in the commit log. Hm? It's now called like it is called in the user manual. Also, the macro SUN4I_CODEC_AC_SYS_VERI was unused before anyway. What should I write in the commit log? > It would be better to add a structure assiocated to the data field of > of_device_id. That way, you'll also be able to have any quirks without > adding more checks (such as a different regmap config, like Chen-Yu > suggested). Yeah, I did that now; seems to work. Cheers, Danny
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v9 0/2] sun4i-codec: Add Line-In, FM-In, Mic 2, Capture Source, Differential Line-In Danny Milosavljevic <dannym@scratchpost.org> - 2016-08-30 07:50 +0200
[PATCH v9 1/2] ASoC: sun4i-codec: Distinguish sun4i from sun7i Danny Milosavljevic <dannym@scratchpost.org> - 2016-08-30 07:50 +0200
Re: [PATCH v9 1/2] ASoC: sun4i-codec: Distinguish sun4i from sun7i Chen-Yu Tsai <wens@csie.org> - 2016-08-31 05:30 +0200
Re: [PATCH v9 1/2] ASoC: sun4i-codec: Distinguish sun4i from sun7i Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-08-31 19:50 +0200
Re: [linux-sunxi] Re: [PATCH v9 1/2] ASoC: sun4i-codec: Distinguish sun4i from sun7i Danny Milosavljevic <dannym@scratchpost.org> - 2016-08-31 22:20 +0200
Re: [linux-sunxi] Re: [PATCH v9 1/2] ASoC: sun4i-codec: Distinguish sun4i from sun7i Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-01 18:50 +0200
csiph-web