Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1473576
| Path | csiph.com!news.freedyn.net!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Sebastian Reichel <sre@kernel.org> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v8 07/11] power: act8945a_charger: Add capacity level property |
| Date | Wed, 31 Aug 2016 17:00:01 +0200 |
| Message-ID | <scf9D-3I8-3@gated-at.bofh.it> (permalink) |
| References | <s9XgR-6iK-5@gated-at.bofh.it> <s9XgS-6iK-43@gated-at.bofh.it> |
| MIME-Version | 1.0 |
| Content-Type | multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="sr2c5r4qnkz35osj" |
| Content-Disposition | inline |
| User-Agent | Mutt/1.6.2-neo (2016-07-23) |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 81 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>, David Woodhouse <dwmw2@infradead.org>, Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>, Mark Brown <broonie@kernel.org>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Kumar Gala <galak@codeaurora.org>, Lee Jones <lee.jones@linaro.org>, Nicolas Ferre <nicolas.ferre@atmel.com>, Alexandre Belloni <alexandre.belloni@free-electrons.com>, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org |
| X-Original-Date | Wed, 31 Aug 2016 16:56:23 +0200 |
| X-Original-Message-ID | <20160831145622.a5pmhddb5fqpzy5z@earth> |
| X-Original-References | <1472109599-21915-1-git-send-email-wenyou.yang@atmel.com> <1472109599-21915-8-git-send-email-wenyou.yang@atmel.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1473576 |
Show key headers only | View raw
[Multipart message — attachments visible in raw view] - view raw
Hi,
On Thu, Aug 25, 2016 at 03:19:55PM +0800, Wenyou Yang wrote:
> Add the power supply capacity level property, it corresponds to
> POWER_SUPPLY_CAPACITY_LEVEL_*.
>
> It also utilizes the precision voltage detector function module
> to catch the low battery voltage.
[...]
> diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig
> index 76806a0..a983de2 100644
> --- a/drivers/power/supply/Kconfig
> +++ b/drivers/power/supply/Kconfig
> @@ -77,7 +77,7 @@ config BATTERY_88PM860X
>
> config BATTERY_ACT8945A
> tristate "Active-semi ACT8945A charger driver"
> - depends on MFD_ACT8945A || COMPILE_TEST
> + depends on MFD_ACT8945A || GPIOLIB || COMPILE_TEST
This looks wrong. You probably wanted (MFD_ACT8945A && GPIOLIB).
But since the gpio consumer headers defines stubs for the !GPIOLIB
case just drop the dependency.
> help
> Say Y here to enable support for power supply provided by
> Active-semi ActivePath ACT8945A charger.
[...]
> + charger->lbo_gpio = devm_gpiod_get(dev, "active-semi,lbo", GPIOD_IN);
> + if (PTR_ERR(charger->lbo_gpio) == -EPROBE_DEFER) {
> + dev_info(dev, "probe retry requested for gpio \"lbo\"\n");
> + return -EPROBE_DEFER;
> + } else if (IS_ERR(charger->lbo_gpio)) {
> + dev_err(dev, "unable to claim gpio \"lbo\"\n");
> + charger->lbo_gpio = NULL;
> + }
Please use devm_gpiod_get_optional():
charger->lbo_gpio = devm_gpiod_get_optional(dev, "active-semi,lbo", GPIOD_IN);
if (IS_ERR(charger->lbo_gpio)) {
err = PTR_ERR(charger->lbo_gpio)
dev_err(dev, "unable to claim gpio \"lbo\": %ld\n", err);
return err;
}
-- Sebastian
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [PATCH v8 07/11] power: act8945a_charger: Add capacity level property Sebastian Reichel <sre@kernel.org> - 2016-08-31 17:00 +0200
csiph-web