Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1473564
| From | Tejun Heo <tj@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2] fs/nfsd/nfs4callback: Remove deprecated create_singlethread_workqueue |
| Date | 2016-08-31 16:50 +0200 |
| Message-ID | <sceZX-3Ew-27@gated-at.bofh.it> (permalink) |
| References | <sbYit-1r7-1@gated-at.bofh.it> <sbYs9-1JI-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hello, Jeff. On Tue, Aug 30, 2016 at 05:07:23PM -0400, Jeff Layton wrote: > Hah! I have almost exactly the same patch in my tree. I've only not > sent it because I haven't had the chance to test it well. > > The only difference in mine is that it passes in WQ_UNBOUND. ISTM that > we don't really need a bound workqueue here since we only use this to > kick off callbacks to the client. I doubt we'd get much out of strictly > maintaining cache locality here, and we're better off just sending it > the callback as quickly as possible. We recently broke strong locality guarantee for users which don't use queue_work_on(), so the default locality is now only for optimization instead of correctness anyway. Unless there are actual benefits to using WQ_UNBOUND, I think in general it's better to stick with as little attributes as possible so that we have more maneuvering room down the line. But, yeah, if this can impact performance in subtle ways, it could be best to just do an identity conversion at least for now. Thanks. -- tejun
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2] fs/nfsd/nfs4callback: Remove deprecated create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-30 23:00 +0200
Re: [PATCH v2] fs/nfsd/nfs4callback: Remove deprecated create_singlethread_workqueue Jeff Layton <jlayton@poochiereds.net> - 2016-08-30 23:10 +0200
Re: [PATCH v2] fs/nfsd/nfs4callback: Remove deprecated create_singlethread_workqueue Tejun Heo <tj@kernel.org> - 2016-08-31 16:50 +0200
Re: [PATCH v2] fs/nfsd/nfs4callback: Remove deprecated create_singlethread_workqueue Jeff Layton <jlayton@redhat.com> - 2016-08-31 17:10 +0200
csiph-web