Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1473560

Re: [PATCH v20 00/20] perf, tools: Add support for PMU events in JSON format

From Andi Kleen <ak@linux.intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH v20 00/20] perf, tools: Add support for PMU events in JSON format
Date 2016-08-31 16:50 +0200
Message-ID <sceZX-3Ew-15@gated-at.bofh.it> (permalink)
References <rMlaF-Mm-3@gated-at.bofh.it> <sccbM-1TJ-35@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


> hi,
> I had discussion with Ingo about the state of this patchset
> and there's one more requirement from his side - to split
> event files into per topic files

Thanks Jiri.
> 
> I made some initial changes over latest Sukadev's branch
> and came up with something like this:

Did you just split it by the "Topic" fields?

> 
> 	$ find pmu-events/arch/x86/
> 	pmu-events/arch/x86/
> 	pmu-events/arch/x86/NehalemEX_core
> 	pmu-events/arch/x86/NehalemEX_core/Memory.json
> 	pmu-events/arch/x86/NehalemEX_core/Virtual-Memory.json
> 	pmu-events/arch/x86/NehalemEX_core/Cache.json
> 	pmu-events/arch/x86/NehalemEX_core/Pipeline.json
> 	pmu-events/arch/x86/NehalemEX_core/Floating-point.json
> 	pmu-events/arch/x86/NehalemEX_core/Other.json
> 	pmu-events/arch/x86/mapfile.csv
> 	pmu-events/arch/x86/Broadwell_core
> 	pmu-events/arch/x86/Broadwell_core/Memory.json
> 	pmu-events/arch/x86/Broadwell_core/Virtual-Memory.json
> 	pmu-events/arch/x86/Broadwell_core/Cache.json
> 	pmu-events/arch/x86/Broadwell_core/Pipeline.json
> 	pmu-events/arch/x86/Broadwell_core/Floating-point.json
> 	pmu-events/arch/x86/Broadwell_core/Other.json
> 	pmu-events/arch/x86/Broadwell_core/Frontend.json
> 
> so let's have a discussion if this is acceptable for you guys

Splitting is fine for me, as long as it's scriptable.

I already have some scripts to generate the perf json files,
can update them to split.

> 
> I've already made some changes in pmu-events/* to support
> this hierarchy to see how bad the change would be.. and
> it's not that bad ;-)

Everything has to be automated, please no manual changes.

-Andi

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH v20 00/20] perf, tools: Add support for PMU events in  JSON format Jiri Olsa <jolsa@redhat.com> - 2016-08-31 13:50 +0200
  Re: [PATCH v20 00/20] perf, tools: Add support for PMU events in  JSON format Andi Kleen <ak@linux.intel.com> - 2016-08-31 16:50 +0200
    Re: [PATCH v20 00/20] perf, tools: Add support for PMU events in  JSON format Jiri Olsa <jolsa@redhat.com> - 2016-08-31 17:00 +0200
      Re: [PATCH v20 00/20] perf, tools: Add support for PMU events in  JSON format Andi Kleen <ak@linux.intel.com> - 2016-08-31 18:20 +0200
        Re: [PATCH v20 00/20] perf, tools: Add support for PMU events in  JSON format Jiri Olsa <jolsa@redhat.com> - 2016-09-01 08:50 +0200

csiph-web