[PATCH 2/5] i2c: tegra: If fifo flush fails return error

From	Shardar Shariff Md <smohammed@nvidia.com>
Newsgroups	linux.kernel
Subject	[PATCH 2/5] i2c: tegra: If fifo flush fails return error
Date	2016-08-31 15:30 +0200
Message-ID	<scdKy-2UO-7@gated-at.bofh.it> (permalink)
References	<scdKy-2UO-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

During i2c controller initialization, when fifo flush fails return error
instead of returning the error during exit.

Signed-off-by: Shardar Shariff Md <smohammed@nvidia.com>

---
Changes in v11:
- Fix smatch error for below warning
  tegra_i2c_init warn: unused return: err = tegra_i2c_flush_fifos()
---
---
 drivers/i2c/busses/i2c-tegra.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
index e93c72a..07a39b7 100644
--- a/drivers/i2c/busses/i2c-tegra.c
+++ b/drivers/i2c/busses/i2c-tegra.c
@@ -494,6 +494,8 @@ static int tegra_i2c_init(struct tegra_i2c_dev *i2c_dev)
 	i2c_writel(i2c_dev, val, I2C_FIFO_CONTROL);
 
 	err = tegra_i2c_flush_fifos(i2c_dev);
+	if (err)
+		goto err;
 
 	if (i2c_dev->is_multimaster_mode && i2c_dev->hw->has_slcg_override_reg)
 		i2c_writel(i2c_dev, I2C_MST_CORE_CLKEN_OVR, I2C_CLKEN_OVERRIDE);
-- 
1.8.1.5

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 2/5] i2c: tegra: If fifo flush fails return error Shardar Shariff Md <smohammed@nvidia.com> - 2016-08-31 15:30 +0200

csiph-web