Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1473469
| From | Shardar Shariff Md <smohammed@nvidia.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v11 2/5] i2c: tegra: If fifo flush fails return error |
| Date | 2016-08-31 15:30 +0200 |
| Message-ID | <scdKy-2UO-27@gated-at.bofh.it> (permalink) |
| References | <scdKy-2UO-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
During i2c controller initialization, when fifo flush fails return error instead of returning the error during exit. Signed-off-by: Shardar Shariff Md <smohammed@nvidia.com> --- Changes in v11: - Fix smatch error for below warning tegra_i2c_init warn: unused return: err = tegra_i2c_flush_fifos() --- --- drivers/i2c/busses/i2c-tegra.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c index e93c72a..07a39b7 100644 --- a/drivers/i2c/busses/i2c-tegra.c +++ b/drivers/i2c/busses/i2c-tegra.c @@ -494,6 +494,8 @@ static int tegra_i2c_init(struct tegra_i2c_dev *i2c_dev) i2c_writel(i2c_dev, val, I2C_FIFO_CONTROL); err = tegra_i2c_flush_fifos(i2c_dev); + if (err) + goto err; if (i2c_dev->is_multimaster_mode && i2c_dev->hw->has_slcg_override_reg) i2c_writel(i2c_dev, I2C_MST_CORE_CLKEN_OVR, I2C_CLKEN_OVERRIDE); -- 1.8.1.5
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v11 1/5] i2c: tegra: use readl_poll_timeout after config_load reg programmed Shardar Shariff Md <smohammed@nvidia.com> - 2016-08-31 15:30 +0200 [PATCH v11 5/5] i2c: tegra: proper handling of error cases Shardar Shariff Md <smohammed@nvidia.com> - 2016-08-31 15:30 +0200 [PATCH v11 3/5] i2c: tegra: add separate function for config_load programing Shardar Shariff Md <smohammed@nvidia.com> - 2016-08-31 15:30 +0200 [PATCH v11 2/5] i2c: tegra: If fifo flush fails return error Shardar Shariff Md <smohammed@nvidia.com> - 2016-08-31 15:30 +0200 Re: [PATCH v11 1/5] i2c: tegra: use readl_poll_timeout after config_load reg programmed Wolfram Sang <wsa@the-dreams.de> - 2016-09-08 22:40 +0200
csiph-web