Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1473467
| From | Shardar Shariff Md <smohammed@nvidia.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 4/5] i2c: tegra: use atomic poll function during configuration |
| Date | 2016-08-31 15:30 +0200 |
| Message-ID | <scdKy-2UO-17@gated-at.bofh.it> (permalink) |
| References | <scdKy-2UO-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Use readl_poll_timeout_atomic() function as *wait_for_config_load()
function can be called from interrupt context.
Signed-off-by: Shardar Shariff Md <smohammed@nvidia.com>
---
Changes in v10:
- Rebase on top of [PATCH V2 0/9] Some Tegra I2C Updates
Changes in v11:
- Fix checkpatch error of using in_atomic() API
---
---
drivers/i2c/busses/i2c-tegra.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
index daab0ce..2437535 100644
--- a/drivers/i2c/busses/i2c-tegra.c
+++ b/drivers/i2c/busses/i2c-tegra.c
@@ -457,8 +457,13 @@ static int tegra_i2c_wait_for_config_load(struct tegra_i2c_dev *i2c_dev)
reg_offset = tegra_i2c_reg_addr(i2c_dev, I2C_CONFIG_LOAD);
addr = i2c_dev->base + reg_offset;
i2c_writel(i2c_dev, I2C_MSTR_CONFIG_LOAD, I2C_CONFIG_LOAD);
- err = readl_poll_timeout(addr, val, val == 0, 1000,
- I2C_CONFIG_LOAD_TIMEOUT);
+ if (in_interrupt())
+ err = readl_poll_timeout_atomic(addr, val, val == 0,
+ 1000, I2C_CONFIG_LOAD_TIMEOUT);
+ else
+ err = readl_poll_timeout(addr, val, val == 0,
+ 1000, I2C_CONFIG_LOAD_TIMEOUT);
+
if (err) {
dev_warn(i2c_dev->dev,
"timeout waiting for config load\n");
--
1.8.1.5
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/5] i2c: tegra: use readl_poll_timeout after config_load reg programmed Shardar Shariff Md <smohammed@nvidia.com> - 2016-08-31 15:30 +0200 [PATCH 4/5] i2c: tegra: use atomic poll function during configuration Shardar Shariff Md <smohammed@nvidia.com> - 2016-08-31 15:30 +0200 [PATCH 5/5] i2c: tegra: proper handling of error cases Shardar Shariff Md <smohammed@nvidia.com> - 2016-08-31 15:30 +0200 Re: [PATCH 1/5] i2c: tegra: use readl_poll_timeout after config_load reg programmed Shardar Mohammed <smohammed@nvidia.com> - 2016-08-31 15:40 +0200
csiph-web